Skip to content

Commit ffb01c5

Browse files
filipesilvaclydin
authored andcommitted
build: return promise on changelog script
The changelog function makes a promise but doesn't return it, causing a race condition between the process exiting and the promise finishing. On a repository with bigger git history the promise took longer to execute and the process exited first.
1 parent b8cecbb commit ffb01c5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/changelog.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export default function(args: ChangelogOptions, logger: logging.Logger) {
3939
|| ''
4040
).trim();
4141

42-
new Promise((resolve) => {
42+
return new Promise((resolve) => {
4343
(gitRawCommits({
4444
from: args.from,
4545
to: args.to || 'HEAD',

0 commit comments

Comments
 (0)