Regression: project is not working anymore from 6.0.8 -> 6.1.0 (in lerna monorepos) #11685

ctaepper · 2018-07-27T08:28:27Z

Bug Report or Feature Request (mark with an `x`)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an `x`)

- [x] all

Repro steps

Our angular/cli project ist located as one package of a larger lerna monorepo. We also make use of yarn workspaces, so all (or most) dependencies are hoisted within one single root node_modules folder. The resulting structure is something like

- node_modules <-- angular dependencies installed here
  - @angular
    - cli
    - core
    - ...
- packages
  - angular-app
    - package.json <-- angular dependencies defined here
    - src
    - ....
- package.json <-- no angular dependencies defined here

this line now (as of 6.1.0) prevents the project from working (at all) because relativePotential.startsWith('..') === true because in our structure relativePotential = ../../node_modules/@angular/core/package.json

everything was working fine with 6.0.8

The log given by the failure

You seem to not be depending on "@angular/core" and/or "rxjs". This is an error.

Desired functionality

I can work on my angular project with latest versions of everything

The text was updated successfully, but these errors were encountered:

hunhavoc · 2018-07-27T08:56:23Z

Same setup - same issue here. Working on a workaround, I'll let you know if it works.

ctaepper · 2018-07-27T09:25:07Z

I have been playing around with combining lerna packages with angular worspace, so I would pull the angular.json and all related dependencies into the root package. Then the lerna packages would be semantically the same as the angular workspace libraries/applications. This would also "fix" this bug, as the angular project root would be equal to the lerna root. I am confident this will work (and will be cool)

However this is not something we can easily achieve in existing projects and I still see this as regression bug.

jSchez · 2018-07-27T11:13:43Z

Same here. We have tried both Lerna and Rush.js, same result.

ctaepper · 2018-07-30T13:29:03Z

@hansl I am happy to create a PR for this issue. However, this is not really a bug in the code, more like a decision on how you check for dependencies. Is there anything I can do to speed this up?

ctaepper · 2018-07-30T13:31:20Z

maybe there is the need for a setting in angular.json to make clear what is considered to "be within the project"

cormacrelf · 2018-08-01T10:32:43Z

See this issue with linked PRs #3864

ctaepper · 2018-08-02T08:01:11Z

still broken in 6.1.2

ctaepper · 2018-08-10T07:15:04Z

6.1.3 🤷‍♂️

alexeagle · 2018-08-10T16:37:58Z

Added to the top of our backlog

iangregsondev · 2018-08-27T11:57:07Z

In the meantime, not ideal, but a quick fix on the lerna.json file to NOT hoist certain dependencies..

    "bootstrap": {
      "nohoist": [
        "@angular/*",
        "@angular-devkit/build-angular",
        "rxjs",
        "@ngtools/*"
      ]
    }

iangregsondev · 2018-08-27T13:00:58Z

Actually, even this fix above is a nightmare as anything that is used by the UI needs to be set as a NOHOIST ...... So its a lot of packages. Anybody find an alternative fix ?

iangregsondev · 2018-08-27T13:02:56Z

I am using 6.1.5 (installed today).

jSchez · 2018-08-27T13:11:17Z

@appsolutegeek try to add your dependencies in the root package.json. Then you will be able to hoist the dependencies within your packages.

gombosg · 2018-08-29T11:01:37Z

I'm having the same issue, with only using Yarn workspaces. The nohoist option in package.json is indeed a fair temporary fix (thanks @appsolutegeek!) - hopefully this' will be fixed in the future.

iangregsondev · 2018-08-29T13:36:59Z

@gombosg no problem, hopefully, we can update the cli soon, so I can remove the NO HOIST packages.

ctaepper · 2018-09-03T11:14:36Z

sadly, the nohoist option is only available for private packages

also sadly

Added to the top of our backlog

does not seem to mean "this is the very next issue that gets fixed"

ctaepper · 2018-09-07T05:59:50Z

6.2.0, 7.0.0 😔

fabianbru · 2018-09-11T07:16:10Z

Is there any update when the issue will be fixed?

ctaepper · 2018-09-26T13:56:35Z

@hansl 👍

ctaepper · 2018-10-02T11:19:37Z

wait a minute, why did this not land in 6.2.4 ???

ptitjes · 2018-10-06T14:05:34Z

@ctaepper It seems that it went in 7.0.0-rc. Updating only @angular/cli worked for me.

ptitjes · 2018-10-11T10:15:50Z

@alexeagle, @hansl, could we also have the fix on 6.2.x please? Moving to 7.0.0-rc* creates other problems with dependencies that are not ready for 7.0...

johanchouquet · 2019-07-16T08:49:13Z

Hi there, anyone tested monorepo approach with Firebase Cloud Functions ?

The idea: multiple apps for multiple Firebase targets, hosted via Firebase hosting. Each target would be a subdomain. I manage to do that.

But I'm struggling with Firebase Cloud Functions setup to be OK in the monorepo. It just doesn't work for now. Do you have best practices to share ?

jorroll · 2019-07-16T08:58:31Z

@johanchouquet I have an angular monorepo with multiple firebase projects in it, including a firebase functions project. I can confirm it works fine.

johanchouquet · 2019-07-16T09:48:17Z

@thefliik , I'm so glad to hear that it can work.

Then, i have this structure. I created 3 apps with the CLI. So my project structure is:

| projects
  | admin
  | app
  | website
package.json
| node_modules
| functions
  | package.json
  | node_modules
.firebaserc
firebase.json

Everything is standard there. When I do firebase deploy --only functions, it fails when executing the tsc task.
I've this stacktrace:

node_modules/@google-cloud/common/node_modules/gaxios/build/src/index.d.ts(14,66): error TS1005: '>' expected.
node_modules/@google-cloud/common/node_modules/gaxios/build/src/index.d.ts(14,103): error TS1109: Expression expected.
node_modules/firebase-functions/lib/function-builder.d.ts(58,93): error TS1005: ';' expected.
node_modules/firebase-functions/lib/function-builder.d.ts(58,94): error TS1003: Identifier expected.
node_modules/firebase-functions/lib/function-builder.d.ts(58,114): error TS1005: ';' expected.
node_modules/firebase-functions/lib/function-builder.d.ts(63,88): error TS1005: ';' expected.
node_modules/firebase-functions/lib/function-builder.d.ts(63,89): error TS1003: Identifier expected.
node_modules/firebase-functions/lib/function-builder.d.ts(63,109): error TS1005: ';' expected.
node_modules/firebase-functions/lib/function-builder.d.ts(63,110): error TS1131: Property or signature expected.
node_modules/firebase-functions/lib/function-builder.d.ts(63,127): error TS1005: ';' expected.
node_modules/firebase-functions/lib/function-builder.d.ts(63,184): error TS1109: Expression expected.
node_modules/firebase-functions/lib/function-builder.d.ts(63,229): error TS1005: '(' expected.
node_modules/firebase-functions/lib/function-builder.d.ts(64,5): error TS1128: Declaration or statement expected.
node_modules/firebase-functions/lib/function-builder.d.ts(65,5): error TS1128: Declaration or statement expected.
node_modules/firebase-functions/lib/function-builder.d.ts(99,5): error TS1128: Declaration or statement expected.
node_modules/firebase-functions/lib/function-builder.d.ts(117,5): error TS1128: Declaration or statement expected.
node_modules/firebase-functions/lib/function-builder.d.ts(124,5): error TS1128: Declaration or statement expected.
node_modules/firebase-functions/lib/function-builder.d.ts(131,5): error TS1128: Declaration or statement expected.
node_modules/firebase-functions/lib/function-builder.d.ts(138,146): error TS1005: '(' expected.
node_modules/firebase-functions/lib/function-builder.d.ts(140,5): error TS1128: Declaration or statement expected.
node_modules/firebase-functions/lib/function-builder.d.ts(153,5): error TS1128: Declaration or statement expected.
node_modules/firebase-functions/lib/function-builder.d.ts(162,5): error TS1128: Declaration or statement expected.
node_modules/firebase-functions/lib/function-builder.d.ts(168,1): error TS1128: Declaration or statement expected.
node_modules/firebase-functions/lib/function-configuration.d.ts(4,64): error TS1005: ']' expected.
node_modules/firebase-functions/lib/function-configuration.d.ts(4,66): error TS1134: Variable declaration expected.
node_modules/firebase-functions/lib/function-configuration.d.ts(4,153): error TS1005: ';' expected.
node_modules/firebase-functions/lib/function-configuration.d.ts(16,61): error TS1005: ']' expected.
node_modules/firebase-functions/lib/function-configuration.d.ts(16,63): error TS1134: Variable declaration expected.
node_modules/firebase-functions/lib/function-configuration.d.ts(16,93): error TS1005: ';' expected.

I'm not sure if i don't something wrong or anything. I'm using the latest dependencies in the functions/package.json, as follow:

"dependencies": {
    "firebase-admin": "~8.2.0",
    "firebase-functions": "^3.1.0"
  }

So, did you configure something to make Firebase Cloud Functions work fine in the monorepo ?

jorroll · 2019-07-16T12:55:21Z

@johanchouquet it's been a while since I set it up, so I can't remember if I encountered any issues in the beginning.

My folder structure is like so

> apps
  > app_one_name
    > app
    > e2e
    package.json
  > functions
    > src
    > tasks
    package.json
    tsconfig.json
    // ...
  > // ...
> libs
  > lib_one
  > lib_two
  > // ...
.firebaserc
angular.json
firebase.json
package.json
tsconfig.json
// ...

It's set up using yarn with yarn workspaces. The workspace's package.json includes:

{
  "workspaces": {
    "packages": [
      "apps/*",
      "libs/*"
    ]
  }
}

The only other thing of note is that the firebase.json file needs to specify the location of the functions source directory:

{
  "functions": {
    "source": "apps/functions"
  }
}

This all being said, your error message looks like it's coming from a syntax error in a typings file. Have you examined the file causing the error? Looks like it could be caused by an incorrect typescript version. Or perhaps the typings for dependencies are clashing in some way.

🤔 💭 It's times like these I wish github had some sort of direct messaging system, to avoid cluttering issues.

johanchouquet · 2019-07-16T13:06:00Z

Thanks @thefliik.

🤔 💭 It's times like these I wish github had some sort of direct messaging system, to avoid cluttering issues.

So true ^^!

This all being said, your error message looks like it's coming from a syntax error in a typings file. Have you examined the file causing the error? Looks like it could be caused by an incorrect typescript version. Or perhaps the typings for dependencies are clashing in some way.

I'm looking into this right now.

I've created my workspace using Angular Console. So I didn't expect that there would be issues in typescript versions or else. Maybe this is not related, but just saying. BTW, AngularConsole is really amazing.

I'll look into yarn workspaces. Seems to be simpler to deal with Cloud Functions.

jorroll · 2019-07-16T14:10:08Z

@johanchouquet sometimes typescript version errors can be hidden by vscode. VSCode, so long as it is kept updated, seems to always use the latest typescript version for intellisense. If your project has an older version of typescript installed, this means that vscode may not show you errors if you accidentally use a typescript feature that is newer than the typescript version your project is using (or if you depend on a library which, in turn, depends on a newer typescript version than you are using).

For example, a firebase functions project of mine was using typescript ~3.2. But I accidentally pulled in a library which made use of the new readonly Array<T> and as const syntax introduced in typescript 3.4. The error showed up as a strange syntax error at compile time. VSCode understood the syntax (because it was using typescript 3.5 to power intellisense), but the version of typescript using during compilation did not. The version of typescript used during compilation didn't even know how to define the error really. It said something like "variable declaration expected" or "unexpected [".

johanchouquet · 2019-07-16T14:51:25Z

@thefliik , indeed, my tsc version was 3.1.6 in VS Code terminal ! I managed to change it to the same version used in my projects (v3.4.5). But nothing changed: i still have those errors... Very strange behavior.

angular-automatic-lock-bot · 2019-09-09T18:41:05Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

ctaepper changed the title ~~Regression: project is not working anymore from 6.0.8 -> 6.1.0~~ Regression: project is not working anymore from 6.0.8 -> 6.1.0 (in lerna monorepos) Jul 27, 2018

hansl added the comp: schematics/update label Jul 27, 2018

hansl added type: bug/fix freq2: medium severity3: broken labels Aug 2, 2018

alexeagle mentioned this issue Aug 10, 2018

@angular/cli gives error if node_modules is placed in parent folder #11823

Closed

alexeagle added the jira-sync label Aug 27, 2018

ngbot bot added this to the Backlog milestone Aug 27, 2018

alan-agius4 mentioned this issue Sep 17, 2018

Angular CLI doesn't work well with Yarn workspaces #12288

Closed

clydin mentioned this issue Sep 20, 2018

Improved monorepo support #12325

Merged

hansl closed this as completed in #12325 Sep 26, 2018

nicolas-geniteau mentioned this issue Sep 26, 2018

fix(@angular/cli): do not check if node_modules are inside sources dir #12372

Closed

Skyndia mentioned this issue Jan 14, 2019

Angular CLI and monorepos (like lerna, yarn workspaces) #7097

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Regression: project is not working anymore from 6.0.8 -> 6.1.0 (in lerna monorepos) #11685

Regression: project is not working anymore from 6.0.8 -> 6.1.0 (in lerna monorepos) #11685

ctaepper commented Jul 27, 2018 •

edited

Loading

hunhavoc commented Jul 27, 2018 •

edited

Loading

ctaepper commented Jul 27, 2018

jSchez commented Jul 27, 2018

ctaepper commented Jul 30, 2018

ctaepper commented Jul 30, 2018

cormacrelf commented Aug 1, 2018 •

edited

Loading

ctaepper commented Aug 2, 2018

ctaepper commented Aug 10, 2018

alexeagle commented Aug 10, 2018

iangregsondev commented Aug 27, 2018

iangregsondev commented Aug 27, 2018

iangregsondev commented Aug 27, 2018

jSchez commented Aug 27, 2018

gombosg commented Aug 29, 2018 •

edited

Loading

iangregsondev commented Aug 29, 2018

ctaepper commented Sep 3, 2018 •

edited

Loading

ctaepper commented Sep 7, 2018

fabianbru commented Sep 11, 2018

ctaepper commented Sep 26, 2018

ctaepper commented Oct 2, 2018

ptitjes commented Oct 6, 2018

ptitjes commented Oct 11, 2018

johanchouquet commented Jul 16, 2019

jorroll commented Jul 16, 2019

johanchouquet commented Jul 16, 2019 •

edited

Loading

jorroll commented Jul 16, 2019 •

edited

Loading

johanchouquet commented Jul 16, 2019 •

edited

Loading

jorroll commented Jul 16, 2019

johanchouquet commented Jul 16, 2019

angular-automatic-lock-bot bot commented Sep 9, 2019

Regression: project is not working anymore from 6.0.8 -> 6.1.0 (in lerna monorepos) #11685

Regression: project is not working anymore from 6.0.8 -> 6.1.0 (in lerna monorepos) #11685

Comments

ctaepper commented Jul 27, 2018 • edited Loading

Bug Report or Feature Request (mark with an x)

Command (mark with an x)

Repro steps

The log given by the failure

Desired functionality

hunhavoc commented Jul 27, 2018 • edited Loading

ctaepper commented Jul 27, 2018

jSchez commented Jul 27, 2018

ctaepper commented Jul 30, 2018

ctaepper commented Jul 30, 2018

cormacrelf commented Aug 1, 2018 • edited Loading

ctaepper commented Aug 2, 2018

ctaepper commented Aug 10, 2018

alexeagle commented Aug 10, 2018

iangregsondev commented Aug 27, 2018

iangregsondev commented Aug 27, 2018

iangregsondev commented Aug 27, 2018

jSchez commented Aug 27, 2018

gombosg commented Aug 29, 2018 • edited Loading

iangregsondev commented Aug 29, 2018

ctaepper commented Sep 3, 2018 • edited Loading

ctaepper commented Sep 7, 2018

fabianbru commented Sep 11, 2018

ctaepper commented Sep 26, 2018

ctaepper commented Oct 2, 2018

ptitjes commented Oct 6, 2018

ptitjes commented Oct 11, 2018

johanchouquet commented Jul 16, 2019

jorroll commented Jul 16, 2019

johanchouquet commented Jul 16, 2019 • edited Loading

jorroll commented Jul 16, 2019 • edited Loading

johanchouquet commented Jul 16, 2019 • edited Loading

jorroll commented Jul 16, 2019

johanchouquet commented Jul 16, 2019

angular-automatic-lock-bot bot commented Sep 9, 2019

ctaepper commented Jul 27, 2018 •

edited

Loading

Bug Report or Feature Request (mark with an `x`)

Command (mark with an `x`)

hunhavoc commented Jul 27, 2018 •

edited

Loading

cormacrelf commented Aug 1, 2018 •

edited

Loading

gombosg commented Aug 29, 2018 •

edited

Loading

ctaepper commented Sep 3, 2018 •

edited

Loading

johanchouquet commented Jul 16, 2019 •

edited

Loading

jorroll commented Jul 16, 2019 •

edited

Loading

johanchouquet commented Jul 16, 2019 •

edited

Loading