Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): fixes cors issues with karma #11970

Merged
merged 1 commit into from
Aug 28, 2018
Merged

fix(@angular-devkit/build-angular): fixes cors issues with karma #11970

merged 1 commit into from
Aug 28, 2018

Conversation

alan-agius4
Copy link
Collaborator

Checking the stack trace in the issue one can noticed that the paths for the components are being served via the webpack:// protocol which is causing a cors issue between http and webpack protocol

This PR removed the webpack protocol from the devtoolModuleFilenameTemplate

Closes #11966

Checking the stack trace in the issue one can noticed that the paths for the components are being served via the `webpack://` protocol which is causing a `cors` issue between `http` and `webpack` protocol

This PR removed the `webpack` protocol from the `devtoolModuleFilenameTemplate`

Closes #11966
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Aug 24, 2018
@vikerman vikerman merged commit 7f67c64 into angular:master Aug 28, 2018
@alan-agius4 alan-agius4 deleted the fix_cors_karma_error branch August 28, 2018 20:23
vikerman pushed a commit that referenced this pull request Aug 29, 2018
)

Checking the stack trace in the issue one can noticed that the paths for the components are being served via the `webpack://` protocol which is causing a `cors` issue between `http` and `webpack` protocol

This PR removed the `webpack` protocol from the `devtoolModuleFilenameTemplate`

Closes #11966
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng test window.onerror ErrorEvent contains Script Error instead of actual error
4 participants