Incorrect declaration files

[alexeagle]

From @mdasberg on May 23, 2018 13:1

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Area

- [x] devkit
- [ ] schematics

Versions

All

Repro steps

Any typescript linter will show the error.

The log given by the failure

...packages/angular_devkit/build_angular/src/browser/schema.d.ts
Unresolved type FIleReplacements
52 | fileReplacements: FileReplacements[];

...packages/angular_devkit/build_angular/src/server/schema.d.ts
Unresolved type FIleReplacements
75 | fileReplacements: FileReplacements[];

Desired functionality

Fix the declaration files see: PR

Mention any other details that might be useful

Copied from original issue: angular/devkit#963

[alexeagle]

From @filipesilva on May 24, 2018 16:45

I'm not sure how you're running this though. We run linting on your repro and the error does not come up.

How exactly are you getting this error? Can you provide repro steps?

[alexeagle]

From @mdasberg on May 24, 2018 18:20

When trying to extend the BrowserBuilder for example, I get errors when trying to compile.
Also if you open those files in your IDE, you will see the errors.

FileReplaceMents is not an interface or class. FileReplacement is.

[alexeagle]

From @mdasberg on May 24, 2018 18:50

For example:

import {BrowserBuilder, NormalizedBrowserBuilderSchema} from '@angular-devkit/build-angular';
import {Path, virtualFs} from '@angular-devkit/core';

import * as fs from 'fs-extra';

export class MyBrowserBuilder extends BrowserBuilder {
    /** {@inheritDoc}. */
    buildWebpackConfig(root: Path, projectRoot: Path, host: virtualFs.Host<fs.Stats>, options: NormalizedBrowserBuilderSchema): any {
        return super.buildWebpackConfig(root, projectRoot, host, options);
    }
}

export default MyBrowserBuilder;

will result in the following errors:

> tsc -p tsconfig.json

node_modules/@angular-devkit/build-angular/src/browser/schema.d.ts(52,21): error TS2304: Cannot find name 'FileReplacements'.
node_modules/@angular-devkit/build-angular/src/server/schema.d.ts(75,21): error TS2304: Cannot find name 'FileReplacements'.

Also notable is that when you change for instance the schema.d.ts file with

fileReplacements: abcde[];

It also passes.

[alexeagle]

From @dwieeb on May 30, 2018 17:44

Also getting this. Not quite sure how this compiles:

notice the additional s at the end

https://github.com/angular/devkit/blob/4fb409d7c1c04d8f0c3d515ba515e470c91bb9da/packages/angular_devkit/build_angular/src/browser/schema.d.ts#L52

https://github.com/angular/devkit/blob/4fb409d7c1c04d8f0c3d515ba515e470c91bb9da/packages/angular_devkit/build_angular/src/browser/schema.d.ts#L265

[alan-agius4]

Duplicate of #11294

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}