Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Ivy in ng test #14547

Closed
alan-agius4 opened this issue May 29, 2019 · 2 comments
Closed

Enable Ivy in ng test #14547

alan-agius4 opened this issue May 29, 2019 · 2 comments
Labels
area: docs Related to the documentation area: @schematics/angular feature Issue that requests a new feature
Milestone

Comments

@alan-agius4
Copy link
Collaborator

alan-agius4 commented May 29, 2019

🚀 Feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [x] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Description

At the moment https://v8.angular.io/guide/ivy documents how to opt-in into Ivy for builds, however this doesn't document how to opt-in into Ivy for tests. The same thing applies when generating a new Ivy application via the CLI. Ivy is only enabled for builds.

Describe the solution you'd like

We should enable the Ivy compiler for tests as well, for both JIT and AOT mode, This is needed, because when enabling the enableIvy compiler option in JIT mode it will use process the packages with ngcc and will use the Ivy engine which also improves runtime speed in JIT mode.

There are 2 ways that I can think of to achieve this. Either by adding enableIvy: true to the specs tsconfig, or the specs tsconfig extends the app tsconfig.

@alan-agius4 alan-agius4 changed the title Enable ivy in ng test Enable Ivy in ng test May 29, 2019
@alan-agius4 alan-agius4 added area: @schematics/angular area: docs Related to the documentation labels May 29, 2019
@ngbot ngbot bot added this to the Backlog milestone May 29, 2019
@alan-agius4 alan-agius4 added the feature Issue that requests a new feature label May 29, 2019
@filipesilva filipesilva modified the milestones: Backlog, 8.0.1 May 29, 2019
@alan-agius4 alan-agius4 modified the milestones: 8.0.x, 8.1.x, 8.2.x Jul 2, 2019
@filipesilva
Copy link
Contributor

Closed via #15044, given that tests only run in JIT at the moment.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: docs Related to the documentation area: @schematics/angular feature Issue that requests a new feature
Projects
None yet
Development

No branches or pull requests

2 participants