-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(karma): set defaults for karma.conf.js #1837
Conversation
0075d6f
to
ad8f1b7
Compare
Note, I ran into this issue when trying to add the following to the karma.conf.js:
With the current karma plugin all webpack and webpackMiddleware configuration in karma.conf.js is overwritten. With this fix the defaults are set for webpack and webpackMiddleware, and any values set in karma.conf.js will also be applied, and/or overwrite the defaults. |
24d64f9
to
371e2c4
Compare
Cleaned up PR to create variable instead of using inline object. |
a419523
to
914c4a7
Compare
384d459
to
b52886f
Compare
The karma plugin is currently overwriting configuration set in karma.conf.js instead of merging existing values. This fix will set defaults but not overwrite existing configuration.
b52886f
to
8baf151
Compare
The karma plugin is currently overwriting configuration set in karma.conf.js instead of merging existing values. This fix will set defaults but not overwrite existing configuration.
The karma plugin is currently overwriting configuration set in karma.conf.js instead of merging existing values. This fix will set defaults but not overwrite existing configuration.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The karma plugin is currently overwriting configuration set in karma.conf.js instead of merging existing values. This fix will set defaults but not overwrite existing configuration.