update migration to remove solution style tsconfig is not run #18744

Splaktar · 2020-09-09T19:31:02Z

🐞 Bug report

Command (mark with an `x`)

Is this a regression?

No

Description

Running ng update @angular/cli to update to v10.1.0 from v10.0.8 does not run the migration to remove solution style tsconfigs.

🔬 Minimal Reproduction

ng update @angular/cli

Your global Angular CLI version (10.1.0) is greater than your local
version (10.0.8). The local Angular CLI version is used.

To disable this warning use "ng config -g cli.warnings.versionMismatch false".
The installed local Angular CLI version is older than the latest stable version.
Installing a temporary version to perform the update.
Installing packages for tooling via npm.
Installed packages for tooling via npm.
Using package manager: 'npm'
Collecting installed dependencies...
Found 54 dependencies.
Fetching dependency metadata from registry...
    Updating package.json with dependency @angular-devkit/build-angular @ "0.1001.0" (was "0.1000.8")...
    Updating package.json with dependency @angular/cli @ "10.1.0" (was "10.0.8")...
UPDATE package.json (3764 bytes)
✔ Packages installed successfully.
splaktar:xlts.dev splaktar$ npm i
npm WARN @angular/fire@6.0.0 requires a peer of @angular/common@^9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/fire@6.0.0 requires a peer of @angular/core@^9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/fire@6.0.0 requires a peer of @angular/platform-browser@^9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/fire@6.0.0 requires a peer of @angular/platform-browser-dynamic@^9.0.0 but none is installed. You must install peer dependencies yourself.

removed 4 packages and audited 2828 packages in 12.241s

126 packages are looking for funding
  run `npm fund` for details

found 4 high severity vulnerabilities
  run `npm audit fix` to fix them, or `npm audit` for details

Notice that there are no migrations run
Check that tsconfig.base.json still exists

🔥 Exception or Error

None

🌍 Your Environment

Before


Angular CLI: 10.0.8
Node: 12.16.1
OS: darwin x64

Angular: 10.1.0
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.1000.8
@angular-devkit/build-angular     0.1000.8
@angular-devkit/build-optimizer   0.1000.8
@angular-devkit/build-webpack     0.1000.8
@angular-devkit/core              9.1.12
@angular-devkit/schematics        9.1.12
@angular/cdk                      10.1.3
@angular/cli                      10.0.8
@angular/fire                     6.0.0
@angular/material                 10.1.3
@ngtools/webpack                  10.0.8
@schematics/angular               9.1.12
@schematics/update                0.1000.8
rxjs                              6.6.2
typescript                        3.9.7
webpack                           4.43.0

After


Angular CLI: 10.1.0
Node: 12.16.1
OS: darwin x64

Angular: 10.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.1001.0 (cli-only)
@angular-devkit/build-angular     0.1001.0
@angular-devkit/build-optimizer   0.1001.0
@angular-devkit/build-webpack     0.1001.0
@angular-devkit/core              9.1.12
@angular-devkit/schematics        9.1.12
@angular/cdk                      10.1.3
@angular/fire                     6.0.0
@angular/material                 10.1.3
@ngtools/webpack                  10.1.0
@schematics/angular               9.1.12
@schematics/update                0.1001.0
rxjs                              6.6.2
typescript                        4.0.2
webpack                           4.44.1

Anything else relevant?
I'm not sure why it's showing 9.1.12 for @angular-devkit/core, @angular-devkit/schematics, and @schematics/angular.

Here's the output of npm ls @angular-devkit/core:

├─┬ @angular-devkit/architect@0.1000.8
│ └── @angular-devkit/core@10.0.8 
├─┬ @angular-devkit/build-angular@0.1000.8
│ ├─┬ @angular-devkit/architect@0.1000.8
│ │ └── @angular-devkit/core@10.0.8  deduped
│ ├─┬ @angular-devkit/build-webpack@0.1000.8
│ │ ├─┬ @angular-devkit/architect@0.1000.8
│ │ │ └── @angular-devkit/core@10.0.8  deduped
│ │ └── @angular-devkit/core@10.0.8 
│ ├── @angular-devkit/core@10.0.8 
│ └─┬ @ngtools/webpack@10.0.8
│   └── @angular-devkit/core@10.0.8 
├─┬ @angular/cli@10.0.8
│ ├─┬ @angular-devkit/architect@0.1000.8
│ │ └── @angular-devkit/core@10.0.8  deduped
│ ├── @angular-devkit/core@10.0.8 
│ ├─┬ @angular-devkit/schematics@10.0.8
│ │ └── @angular-devkit/core@10.0.8  deduped
│ ├─┬ @schematics/angular@10.0.8
│ │ └── @angular-devkit/core@10.0.8  deduped
│ └─┬ @schematics/update@0.1000.8
│   ├── @angular-devkit/core@10.0.8 
│   └─┬ @angular-devkit/schematics@10.0.8
│     └── @angular-devkit/core@10.0.8  deduped
├─┬ @schuchard/prettier@3.1.0
│ ├── @angular-devkit/core@7.3.9 
│ └─┬ @angular-devkit/schematics@7.3.9
│   └── @angular-devkit/core@7.3.9  deduped
└─┬ @scullyio/init@1.0.0-beta.0
  ├── @angular-devkit/core@9.1.12 
  ├─┬ @angular-devkit/schematics@9.1.12
  │ └── @angular-devkit/core@9.1.12  deduped
  ├─┬ @schematics/angular@9.1.12
  │ └── @angular-devkit/core@9.1.12  deduped
  └─┬ schematics-utilities@2.0.2
    ├── @angular-devkit/core@8.3.29 
    ├─┬ @angular-devkit/schematics@8.3.29
    │ └── @angular-devkit/core@8.3.29  deduped
    ├─┬ @schematics/angular@8.3.29
    │ └── @angular-devkit/core@8.3.29  deduped
    └─┬ @schematics/update@0.803.29
      └── @angular-devkit/core@8.3.29  deduped

Here's the output of npm ls @schematics/angular:

├─┬ @angular/cli@10.0.8
│ └── @schematics/angular@10.0.8 
└─┬ @scullyio/init@1.0.0-beta.0
  ├── @schematics/angular@9.1.12 
  └─┬ schematics-utilities@2.0.2
    └── @schematics/angular@8.3.29

The text was updated successfully, but these errors were encountered:

Splaktar · 2020-09-09T19:39:44Z

I thought that perhaps Scully was causing issues since it had the older versions, but removing it actually resulted in an error (rather than things working properly):

$ ng update @angular/cli
Your global Angular CLI version (10.1.0) is greater than your local
version (10.0.8). The local Angular CLI version is used.

To disable this warning use "ng config -g cli.warnings.versionMismatch false".
The "@angular-devkit/schematics" package cannot be resolved from the workspace root directory. This may be due to an unsupported node modules structure.
Please remove both the "node_modules" directory and the package lock file; and then reinstall.
If this does not correct the problem, please temporarily install the "@angular-devkit/schematics" package within the workspace. It can be removed once the update is complete.
splaktar:xlts.dev splaktar$ npm ls @angular-devkit/schematics
xlts.dev@0.2.0 /Users/splaktar/Git/devintent/xlts/xlts.dev
├─┬ @angular/cli@10.0.8
│ ├── @angular-devkit/schematics@10.0.8 
│ ├─┬ @schematics/angular@10.0.8
│ │ └── @angular-devkit/schematics@10.0.8  deduped
│ └─┬ @schematics/update@0.1000.8
│   └── @angular-devkit/schematics@10.0.8 
└─┬ @schuchard/prettier@3.1.0
  └── @angular-devkit/schematics@7.3.9

Splaktar · 2020-09-09T19:54:36Z

Workaround

With my Scully libs put back in and everything restored to the original state:

rm -rf node_modules/
rm package-lock.json
npm i
ng update @angular/cli

Your global Angular CLI version (10.1.0) is greater than your local
version (10.0.8). The local Angular CLI version is used.

To disable this warning use "ng config -g cli.warnings.versionMismatch false".
The installed local Angular CLI version is older than the latest stable version.
Installing a temporary version to perform the update.
Installing packages for tooling via npm.
Installed packages for tooling via npm.
Repository is not clean. Update changes will be mixed with pre-existing changes.
Using package manager: 'npm'
Collecting installed dependencies...
Found 54 dependencies.
Fetching dependency metadata from registry...
    Updating package.json with dependency @angular-devkit/build-angular @ "0.1001.0" (was "0.1000.8")...
    Updating package.json with dependency @angular/cli @ "10.1.0" (was "10.0.8")...
UPDATE package.json (3757 bytes)
✔ Packages installed successfully.
** Executing migrations of package '@angular/cli' **

❯ Removing "Solution Style" TypeScript configuration file support.
DELETE tsconfig.base.json
UPDATE tsconfig.json (795 bytes)
UPDATE tsconfig.spec.json (385 bytes)
UPDATE projects/angularjs.xlts.dev/tsconfig.app.json (190 bytes)
UPDATE projects/xlts.dev/tsconfig.app.json (190 bytes)
  Migration completed.

Splaktar · 2020-09-09T19:56:40Z

Questions

Can the situation with The "@angular-devkit/schematics" package cannot be resolved from the workspace root directory. be improved?

First it didn't find the latest version and used a version from a library that didn't match the version used by the CLI. There was no warning or error here. It seems like there should have been when doing ng update to 10.1 and the update using schematic libs from 9.1.
Second, it didn't find the schematics package when it was clearly visible to npm ls. Why? Is there a bug in this package resolution code?

cwhaught · 2020-09-09T20:05:19Z

I am encountering a similar if not the same problem.

I have tsconfig.base.json(but no tsconfig.json) in the root of my project and get a failure of

[error] Error: Could not read 'tsconfig.json'.
    at new JSONFile (<path_to_repo>/node_modules/@schematics/angular/utility/json-file.js:22:19)

every time I try to run

ng update @angular/cli @angular/core

Splaktar · 2020-09-09T20:15:39Z

@cwhaught that seems like a separate issue. Can you please open a new issue for it?

cwhaught · 2020-09-09T20:24:06Z

Apologies @Splaktar, I thought I saw the same error in your comments at first glance.

alan-agius4 · 2020-09-10T09:47:21Z

Hi @Splaktar,

Find below the answers to your questions, feel free to ask more 😀.

Can the situation with The "@angular-devkit/schematics" package cannot be resolved from the workspace root directory. be improved?

This should be handled with the new version of schematics, aka schematics runtime, which is still currently in it's early design phase.

First it didn't find the latest version and used a version from a library that didn't match the version used by the CLI. There was no warning or error here. It seems like there should have been when doing ng update to 10.1 and the update using schematic libs from 9.1.

Maybe we can issue a warning when the installed @angular/cli version and @schematics/angular mismatch.

Second, it didn't find the schematics package when it was clearly visible to npm ls. Why? Is there a bug in this package resolution code?

While npm ls does list @angular-devkit/schematics, none of these is directly under the root level node_modules directory. This resolution is intended, this is because certain packages with schematics will not have @angular-devkit/schematics as a direct dependency. One such package is @angular/core, in which case having the above node_module structure will cause failures when running ng update @angular/core. Te schematic runtime will handle such situation, however this concept is still in it's early design phase.

Side note: I'd suggest that a lock file maintain is done periodically. Overtime when packages are added and updated, the presence of a lock file will hinder package hoisting and deduping.

There are two quick ways to do such maintainance:

If your project is on GitHub, enable Renovate bot lock file maintenance feature..
Run rm -rf node_modules package-lock.json && npm i

KingDarBoja · 2020-10-19T16:42:36Z

I ran the following command and it worked out:

ng update @angular/cli --from=10.0.0 --to=10.1.3 --migrateOnly=true

As I forgot to use ng update after updating my packages with npm-check-updates to latest CLI version (v10.1.3).

alan-agius4 · 2020-11-16T11:20:28Z

I am going to close this issue as this is a known limitation which is caused by the decision of not have explicit dependencies in a library and unfortunately, at this point there is not much we can do without a total re-design of how ng update works.

Splaktar · 2020-11-23T07:17:24Z

Maybe we can issue a warning when the installed @angular/cli version and @schematics/angular mismatch.

This would be helpful to at least give people an idea of where to start investigating. It doesn't look like this was pursued in @angular/cli?

Would you suggest that all schematic library authors out there start doing checks like this? Is that even something that a library would be able to evaluate at runtime? or would this have to be done in the CLI?

alan-agius4 · 2020-11-23T09:13:44Z

Would you suggest that all schematic library authors out there start doing checks like this? Is that even something that a library would be able to evaluate at runtime? or would this have to be done in the CLI?

Typically 3rd party users using schematics will list their dependencies explicitly and in many cases users if they are using @schematics/angular, @angular-devkit/schematics etc...

Side note: typically 3rd party libraries shouldn't dependent on @schematics/angular as most of the APIs in that package are private and not meant to be used by downstream users.

Splaktar · 2020-11-23T09:20:51Z

Right, should the warning be for when the default "resolved" @angular-devkit/schematics and @angular-devkit/core versions do not match the version of @angular-devkit/build-angular or @angular/cli (roughly)?

MrP · 2020-12-18T07:52:03Z

I ran the following command and it worked out:

ng update @angular/cli --from=10.0.0 --to=10.1.3 --migrateOnly=true

As I forgot to use ng update after updating my packages with npm-check-updates to latest CLI version (v10.1.3).

Thanks for this, it worked great for me with Angular 11.

If anybody like me missed the migration back to non-solution-style tsconfig during v10, then updated to 11, then tried to migrate to eslint and was confrontend with an error message telling you off for still having around a tsconfig.base.json, then this solution is also for you. Just to be explicit, I ran the command above as is, even though I was at v11 of everything already.

Oh, and that was after manually installing @angular-devkit/schematics, but I didn't test without it, so I don't know if that is part of the solution as well.

angular-automatic-lock-bot · 2021-02-28T08:11:27Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

destus90 mentioned this issue Sep 10, 2020

New "Solution Style" tsconfig.json file breaks the unused files in most Editors #18040

Closed

alan-agius4 added area: @angular/cli ng update DX labels Sep 10, 2020

ngbot bot modified the milestone: needsTriage Sep 10, 2020

eranshmil mentioned this issue Sep 22, 2020

fix(@schematics/angular): remove solution style throw an error #18851

Merged

alan-agius4 mentioned this issue Nov 16, 2020

bug(update): Cannot find module '@angular-devkit/core/src/workspace/json/reader' angular/components#21045

Closed

alan-agius4 closed this as completed Nov 16, 2020

alan-agius4 reopened this Nov 23, 2020

alan-agius4 mentioned this issue Dec 4, 2020

When Upgrading from Angular 10 to Angular 11, missing-injectable Schematic Throws Exception angular/angular#39953

Closed

alan-agius4 changed the title ~~update(10.1): migration to remove solution style tsconfig is not run~~ update migration to remove solution style tsconfig is not run Jan 28, 2021

alan-agius4 linked a pull request Jan 28, 2021 that will close this issue

fix(@angular/cli): direct Angular schematic dependency requests to known versions #19857

Merged

alan-agius4 closed this as completed in #19857 Jan 28, 2021

angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update migration to remove solution style tsconfig is not run #18744

update migration to remove solution style tsconfig is not run #18744

Splaktar commented Sep 9, 2020

Splaktar commented Sep 9, 2020 •

edited

Loading

Splaktar commented Sep 9, 2020

Splaktar commented Sep 9, 2020

cwhaught commented Sep 9, 2020

Splaktar commented Sep 9, 2020

cwhaught commented Sep 9, 2020

alan-agius4 commented Sep 10, 2020

KingDarBoja commented Oct 19, 2020

alan-agius4 commented Nov 16, 2020

Splaktar commented Nov 23, 2020

alan-agius4 commented Nov 23, 2020 •

edited

Loading

Splaktar commented Nov 23, 2020

MrP commented Dec 18, 2020 •

edited

Loading

angular-automatic-lock-bot bot commented Feb 28, 2021

update migration to remove solution style tsconfig is not run #18744

update migration to remove solution style tsconfig is not run #18744

Comments

Splaktar commented Sep 9, 2020

🐞 Bug report

Command (mark with an x)

Is this a regression?

Description

🔬 Minimal Reproduction

🔥 Exception or Error

🌍 Your Environment

Before

After

Splaktar commented Sep 9, 2020 • edited Loading

Splaktar commented Sep 9, 2020

Workaround

Splaktar commented Sep 9, 2020

Questions

cwhaught commented Sep 9, 2020

Splaktar commented Sep 9, 2020

cwhaught commented Sep 9, 2020

alan-agius4 commented Sep 10, 2020

KingDarBoja commented Oct 19, 2020

alan-agius4 commented Nov 16, 2020

Splaktar commented Nov 23, 2020

alan-agius4 commented Nov 23, 2020 • edited Loading

Splaktar commented Nov 23, 2020

MrP commented Dec 18, 2020 • edited Loading

angular-automatic-lock-bot bot commented Feb 28, 2021

Command (mark with an `x`)

Splaktar commented Sep 9, 2020 •

edited

Loading

alan-agius4 commented Nov 23, 2020 •

edited

Loading

MrP commented Dec 18, 2020 •

edited

Loading