Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keeping the file stats while copying assets #29797

Closed
williamdes opened this issue Mar 10, 2025 · 3 comments · Fixed by #29933
Closed

Support keeping the file stats while copying assets #29797

williamdes opened this issue Mar 10, 2025 · 3 comments · Fixed by #29933
Labels
angular/build:application area: @angular/build feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature

Comments

@williamdes
Copy link

williamdes commented Mar 10, 2025

Command

build

Description

I am not sure that you are aware that users have made a patch for this feature, but did not report it here.
Patch: https://stackoverflow.com/a/77390012/5155484

I want the copy command to copy the modification time of my files so I am able to sync to S3 or other content providers files that do not have a changed date at each deployment.
This will allow assets to live longer on cached proxies, if the last modified date is not always changed.

That means that I can deploy like this:

Describe the solution you'd like

Modify build-angular/src/utils/copy-assets.js async function copyAssets with an option top copy file stats

Describe alternatives you've considered

Applying the patch in a sloppy way

Copy link
Contributor

angular-robot bot commented Mar 12, 2025

This feature request is now candidate for our backlog! In the next phase, the community has 60 days to upvote. If the request receives more than 20 upvotes, we'll move it to our consideration list.

You can find more details about the feature request process in our documentation.

@angular-robot angular-robot bot added the feature: votes required Feature request which is currently still in the voting phase label Mar 12, 2025
@jkrems
Copy link
Contributor

jkrems commented Mar 12, 2025

For context: What is the reason not to use ETag for the blob storage objects which isn't as sensitive to exact mtimes? Is it because support for it outside of S3 isn't always there?

@williamdes
Copy link
Author

For context: What is the reason not to use ETag for the blob storage objects which isn't as sensitive to exact mtimes? Is it because support for it outside of S3 isn't always there?

Yes Etag is used on S3, but other deployments for example nginx will not have it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular/build:application area: @angular/build feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants