-
Notifications
You must be signed in to change notification settings - Fork 12k
HTML minification #3459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Benchmarked this on my own project. With AOT - my main bundle was around 606kb without html minification and 602kb with. Numbers are for the pre-gzip prod files. I imagine the gzip reduces the difference further. |
We are discussing using Closing this as a dupe of #3415 |
@hansl Personally I'd like to see this left open unless you want to change #3415 to a general "Fix what we lost by removing html-loader" ticket. Yeah, html-loader does both html minification and image fingerprinting, but otherwise there's no relation between the two feature requests - you can have html minification without fingerprinting and fingerprinting without minification. |
We will not do html minification unless we implement html-loader, so they're related. |
What's the reasoning for that? It shouldn't be difficult to create a loader that only does html minification if you decide html-loader has too much other baggage to deal with. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Trying to track down some build size issues and at first glance it seems like there's no HTML minification being performed even in a prod build. I'm guessing this was either never in place or was lost with the removal of html-loader. What's the roadmap here? Is the AOT compiler supposed to handle this somehow? If not, can we add a loader that at least does the minification?
OS?
Windows 10
Versions.
angular-cli: 1.0.0-beta.22-1
node: 6.9.1
os: win32 x64
The text was updated successfully, but these errors were encountered: