refactor(lint): use tslint api for linting #4248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delasteve
commented
Jan 27, 2017
| @@ -41,7 +40,6 @@ | |||
| "karma-remap-istanbul": "^0.2.1", | |||
| "protractor": "~4.0.13", | |||
| "ts-node": "1.2.1", | |||
| "tslint": "^4.3.0", | |||
There was a problem hiding this comment.
@hansl please let me know if you want this line back in. It's technically not necessary anymore since it's using the CLI tslint dependency and not the project's dependency.
filipesilva
suggested changes
Jan 27, 2017
There was a problem hiding this comment.
I have three requests for this PR:
- I don't think we should use
tslintfrom the CLI. It removes the user's ability to update it (or codelyzer), and is generally confusing. I understand a big argument against that is that we now rely on thetslintapi... but we also do that for karma. So the real answer to that is to check for compatible versions when running the command (not overly important for this PR, mostly a note for the future). - We need some tests for the
--forceand--formatflags in https://github.com/angular/angular-cli/blob/master/tests/e2e/tests/test/lint.ts - We need to either be backwards compatible (using
npm runif there's no config maybe?) or give a reasonable warning telling users what they need to change to upgrade. As is, upgraders wouldn't be able to runng lint.
Aside from that it's great to have better linting support, and a lot of people will appreciate the --format flag as well I bet.
I should probably do the same for ng e2e.
delasteve
force-pushed
the
refactor/linting-ts-files
branch
5 times, most recently
from
d246fd9 to
ebf9515
Compare
Closes angular#867, angular#3993 BREAKING CHANGE: In order to use the updated `ng lint` command, the following section will have to be added to the project's `angular-cli.json` at the root level of the json object. ```json "lint": [ { "files": "src/**/*.ts", "project": "src/tsconfig.json" }, { "files": "e2e/**/*.ts", "project": "e2e/tsconfig.json" } ], ``` Alternatively, you can run `ng update`.
delasteve
force-pushed
the
refactor/linting-ts-files
branch
from
ebf9515 to
7185866
Compare
filipesilva
approved these changes
Jan 28, 2017
|
Thanks for this awesome update @delasteve ! |
This was referenced Feb 3, 2017
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
Closes angular#867, angular#3993 BREAKING CHANGE: In order to use the updated `ng lint` command, the following section will have to be added to the project's `angular-cli.json` at the root level of the json object. ```json "lint": [ { "files": "src/**/*.ts", "project": "src/tsconfig.json" }, { "files": "e2e/**/*.ts", "project": "e2e/tsconfig.json" } ], ``` Alternatively, you can run `ng update`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #867 and #3993