Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): remove component generation from module generation #4706

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Feb 15, 2017

Fixes #4209

BREAKING CHANGE: Generating a module with routing will no longer generate an associated component.

@Brocco Brocco requested review from hansl and filipesilva February 15, 2017 02:13
@Brocco Brocco force-pushed the remove-route-component branch from 5814bbb to 5f3b11f Compare February 15, 2017 11:47
@Brocco Brocco force-pushed the remove-route-component branch from 5f3b11f to 6824ccb Compare February 15, 2017 14:28
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Fixes angular#4209

BREAKING CHANGE: Generating a module with routing will no longer generate an associated component.
@Brocco Brocco force-pushed the remove-route-component branch from 6824ccb to 1e3b115 Compare February 16, 2017 01:38
@Brocco Brocco merged commit 9db71d8 into angular:master Feb 16, 2017
@Brocco Brocco deleted the remove-route-component branch March 15, 2017 17:46
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
…angular#4706)

Fixes angular#4209

BREAKING CHANGE: Generating a module with routing will no longer generate an associated component.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Remove component generation when generating modules w/ routing
4 participants