Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add async method in Jasmine Tests #4775

Merged
merged 3 commits into from
Feb 21, 2017
Merged

Conversation

wKoza
Copy link
Contributor

@wKoza wKoza commented Feb 17, 2017

Add async method if we use compileComponents() because compileComponents is asynchronous

PR #4774

@hansl hansl requested a review from filipesilva February 17, 2017 19:15
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change the usage of .compileComponents in these files?

Please change it to match the changes you already have (add async, chain .compileComponents)

@wKoza
Copy link
Contributor Author

wKoza commented Feb 17, 2017

@filipesilva done

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wKoza looks good, just waiting for the CI.

Thanks for updating these!

@hansl hansl merged commit c792c9f into angular:master Feb 21, 2017
sumitarora pushed a commit to sumitarora/angular-cli that referenced this pull request Feb 21, 2017
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants