Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generated Module Spec #5715

Closed
wants to merge 1 commit into from
Closed

Fix generated Module Spec #5715

wants to merge 1 commit into from

Conversation

Hirse
Copy link
Contributor

@Hirse Hirse commented Mar 28, 2017

  • Fix import by using named import
  • Fix TypeScript noImplicitAny by adding a type
  • Fix TSLint by adding a missing semicolon

filipesilva
filipesilva approved these changes Mar 29, 2017
View reviewed changes
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Hirse
Copy link
Contributor Author

Hirse commented Mar 29, 2017

Is this now considered merged?
Should I close the PR?

@Hirse Hirse deleted the fix/module-spec branch March 29, 2017 11:19
@filipesilva
Copy link
Contributor

@Hirse sorry it took me a while to respond, but the PR was only closed later on. We usually review and merge PRs separately.

@filipesilva filipesilva mentioned this pull request Apr 10, 2017
Closed
@Hirse
Copy link
Contributor Author

Hirse commented Apr 10, 2017

No worries.
When I wrote the comment it looked like the commit was merged/cherry-picked somewhere.

dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
@Hirse @dond2clouds
fix(@angular/cli): fix generated Module Spec
44beafb 
Close angular#5715
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hirse @filipesilva @googlebot