Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@angular/cli dependencies leads to incorrect peer dependencies. #7658

Closed
nweldev opened this issue Sep 11, 2017 · 6 comments
Closed

@angular/cli dependencies leads to incorrect peer dependencies. #7658

nweldev opened this issue Sep 11, 2017 · 6 comments

Comments

@nweldev
Copy link
Contributor

nweldev commented Sep 11, 2017

Bug Report or Feature Request (mark with an x)

- [x] bug report
- [ ] feature request

Versions.

@angular/cli: 1.4.0-rc.1
node: 6.11.2
os: win32 x64
@angular/animations: 4.3.6
@angular/common: 4.3.6
@angular/compiler: 4.3.6
@angular/core: 4.3.6
@angular/forms: 4.3.6
@angular/http: 4.3.6
@angular/platform-browser: 4.3.6
@angular/platform-browser-dynamic: 4.3.6
@angular/router: 4.3.6
@angular/cli: 1.4.0-rc.1
@angular/compiler-cli: 4.3.6
@angular/language-service: 4.3.6
typescript: 2.3.4

Repro steps.

ng new whatever
cd whatever
yarn install or npm install

The log given by the failure.

yarn install v1.0.1
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
info fsevents@1.1.2: The platform "win32" is incompatible with this module.
info "fsevents@1.1.2" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning "extract-text-webpack-plugin@3.0.0" has incorrect peer dependency "webpack@^3.1.0".
warning "html-webpack-plugin@2.30.1" has incorrect peer dependency "webpack@1 || ^2 || ^2.1.0-beta || ^2.2.0-rc || ^3".
warning "less-loader@4.0.5" has incorrect peer dependency "less@^2.3.1".
warning "less-loader@4.0.5" has incorrect peer dependency "webpack@^2.0.0 || ^3.0.0".
warning "license-webpack-plugin@1.0.0" has incorrect peer dependency "webpack-sources@>= 1.0.0".
warning "sass-loader@6.0.6" has incorrect peer dependency "node-sass@^4.0.0".
warning "sass-loader@6.0.6" has incorrect peer dependency "webpack@^2.0.0 || >= 3.0.0-rc.0 || ^3.0.0".
warning "@ngtools/webpack@1.7.0-rc.1" has incorrect peer dependency "webpack@^2.2.0 || ^3.0.0".
warning "stylus-loader@3.0.1" has incorrect peer dependency "stylus@>=0.52.4".
warning "url-loader@0.5.9" has incorrect peer dependency "file-loader@*".
warning "webpack-dev-middleware@1.12.0" has incorrect peer dependency "webpack@^1.0.0 || ^2.0.0 || ^3.0.0".
warning "webpack-dev-server@2.7.1" has incorrect peer dependency "webpack@^2.2.0 || ^3.0.0".
warning "@schematics/angular@0.0.33" has incorrect peer dependency "@angular-devkit/schematics@0.0.21". warning "ajv-keywords@2.1.0" has incorrect peer dependency "ajv@>=5.0.0".
warning "uglifyjs-webpack-plugin@0.4.6" has incorrect peer dependency "webpack@^1.9 || ^2 || ^2.1.0-beta || ^2.2.0-rc || ^3.0.0".

Desired functionality.

There should'nt be any warnings about incorrect peer dependencies.

Mention any other details that might be useful.

$ npm list webpack
angular-cli-new140@0.0.0 C:\Users\N2632888\dev\test\angular-cli-new140
`-- @angular/cli@1.4.0-rc.1
  `-- webpack@3.5.6
@neo
Copy link

neo commented Sep 11, 2017

Similar problem: couldn't start the dev server because of:

Cannot find module 'webpack/lib/node/NodeTemplatePlugin'
Error: Cannot find module 'webpack/lib/node/NodeTemplatePlugin'

And saw this while installing:

npm WARN extract-text-webpack-plugin@3.0.0 requires a peer of webpack@^3.1.0 but none is installed. You must install peer dependencies yourself.
npm WARN html-webpack-plugin@2.30.1 requires a peer of webpack@1 || ^2 || ^2.1.0-beta || ^2.2.0-rc || ^3 but none is installed. You must install peer dependencies yourself.
npm WARN less-loader@4.0.5 requires a peer of webpack@^2.0.0 || ^3.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN sass-loader@6.0.6 requires a peer of webpack@^2.0.0 || >= 3.0.0-rc.0 || ^3.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN uglifyjs-webpack-plugin@0.4.6 requires a peer of webpack@^1.9 || ^2 || ^2.1.0-beta || ^2.2.0-rc || ^3.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN webpack-dev-middleware@1.12.0 requires a peer of webpack@^1.0.0 || ^2.0.0 || ^3.0.0 but none is installed. You must install peer dependencies yourself.

@clydin
Copy link
Member

clydin commented Sep 11, 2017

Is yarn configured as the CLI's package manager? It looks like the package manager is erroneously nesting webpack under the CLI dependency.

@devoto13
Copy link
Contributor

It looks like a bug in Yarn 1.0.1 release. See yarnpkg/yarn#4342.

@neo
Copy link

neo commented Sep 11, 2017

oh my god... yarn yarn yarn

@nweldev
Copy link
Contributor Author

nweldev commented Sep 12, 2017

tested with yarn 0.24.6 and there is no warnings ... my bad
thx @devoto13

@nweldev nweldev closed this as completed Sep 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants