Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Continious integration tests broken #317

Closed
programmador opened this issue Mar 10, 2016 · 1 comment
Closed

Continious integration tests broken #317

programmador opened this issue Mar 10, 2016 · 1 comment

Comments

@programmador
Copy link

If you now go to the pull requests list you'll see that lots of them are rejected because of continious integration tests fail. The eror message is:
error: pathspec 'step-{0..12}' did not match any file(s) known to git.

If I change in this line:
https://github.com/angular/angular-phonecat/blob/master/scripts/private/test-all.sh#L28
for i in {0..12}
to
for i in seq 1 12``
the test will run successfully.

I'm not very skilled in bash scripting so I don't know whether using seq command is the best solution here. Also I don't know why {0..12} doesn't work. Anyway please pay attention to this bug and be sure to re-run the continious integration checks on all pending pull requests after fixing it.

@gkalpak
Copy link
Member

gkalpak commented Mar 10, 2016

There's a pull request for that : #280
It'll get merged soon.

Thx for looking into it though :)

Let's track this problem there.

@gkalpak gkalpak closed this as completed Mar 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants