Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Commit

Permalink
fix(http): fix header map type for http.call()
Browse files Browse the repository at this point in the history
Headers could be set to a String or a Function. The type has to be
dynamic.
  • Loading branch information
vicb committed Apr 9, 2014
1 parent 4707826 commit a6cc826
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/core_dom/http.dart
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ class Http {
String method,
data,
Map<String, dynamic> params,
Map<String, String> headers,
Map<String, dynamic> headers,
xsrfHeaderName,
xsrfCookieName,
interceptors,
Expand Down

3 comments on commit a6cc826

@jbdeboer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a test for this change. Looking at the code, I don't think the bug is fixed.

@vicb
Copy link
Contributor Author

@vicb vicb commented on a6cc826 Apr 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll double check that asap. The code/test do not seem to have changed for a while so didn't really dig, just submitted to fix an analyzer warning

@vicb
Copy link
Contributor Author

@vicb vicb commented on a6cc826 Apr 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbdeboer what exact bug do you have in mind ? Look like we have tests for headers being either a String or a closure.

Please sign in to comment.