This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(http): fix header map type for http.call()
Headers could be set to a String or a Function. The type has to be dynamic.
- Loading branch information
a6cc826
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write a test for this change. Looking at the code, I don't think the bug is fixed.
a6cc826
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll double check that asap. The code/test do not seem to have changed for a while so didn't really dig, just submitted to fix an analyzer warning
a6cc826
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbdeboer what exact bug do you have in mind ? Look like we have tests for
headers
being either a String or a closure.