This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
feat(cache): Move cache out of core, add a CacheRegister #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(result).toEqual(6); | ||
| })); | ||
|
|
||
| it('should return a future after being resolved', async(() { |
There was a problem hiding this comment.
it('should return a different future after being resolved
|
LGTM. (other than the one minor comment.) Thanks! |
jbdeboer
added a commit
that referenced
this pull request
Jun 18, 2014
jbdeboer
added a commit
that referenced
this pull request
Jun 18, 2014
|
|
||
| @Injectable() | ||
| class CacheRegister { | ||
| Map<String, Map> _caches = {}; |
There was a problem hiding this comment.
Should it be Map<String, Cache> ?
|
I have added a few inline comments. I would also rename LGTM |
jbdeboer
added a commit
that referenced
this pull request
Jun 24, 2014
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Jul 16, 2014
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Jul 16, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.