This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
feat(scope): move domWrite and domRead from RootScope to Scope #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
force-pushed
the
scope_dom_writes_reads
branch
from
ab06f09 to
c9f50e7
Compare
vsavkin
force-pushed
the
scope_dom_writes_reads
branch
from
c9f50e7 to
db04f6c
Compare
vsavkin
added a commit
to vsavkin/angular.dart
that referenced
this pull request
Sep 10, 2014
jbdeboer
pushed a commit
to jbdeboer/angular.dart
that referenced
this pull request
Sep 11, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
domWriteanddomReadfromRootScopetoScope. This changesdomWriteanddomReadinto trees of functions. This allows us to run all DOM operations bottom-up, which solves a few problems (e.g, #1161).Closes #1161