feat(TestBed): add whitespace handling to compile #1346
Conversation
| @@ -58,12 +58,24 @@ class TestBed { | |||
| return rootElement; | |||
| } | |||
|
|
|||
| String _handleWhitespace(html) { | |||
There was a problem hiding this comment.
Could you please move this private method after all public ones (I find it better to have the API first)
|
Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road. For individuals (a simple click-through form): http://code.google.com/legal/individual-cla-v1.0.html |
|
As you probably guessed, I'm far from a git expert. Again, very sorry. Did I make those changes properly? |
| return html.split('\n').map((line) { | ||
| var trimmed = line.trim(); | ||
| return trimmed + (trimmed.isEmpty || trimmed.endsWith('>') ? '' : ' '); | ||
| }).join(); |
There was a problem hiding this comment.
return html.split('\n')
.map((line) {
var trimmed = line.trim();
return trimmed + (trimmed.isEmpty || trimmed.endsWith('>') ? '' : ' '); })
.join();
No worries, you'll become an expert soon. You should squash the commit so that there is only 1 commit in your branch and then force push to github (push -f). You'll be ok the commit count on top of this page is "1".
I have made a minor comment on the formatting |
|
Alright, got it! Thanks so much for the help! |
Add whitespace handling to the TestBed’s compile function. Closes #1262. Previously, strings passed with leading or trailing whitespace would be compiled incorrectly. Now, valid HTML with arbitrary whitespace in and surrounding it can be compiled properly.
|
👍 |
|
Achievement unlocked: CLA signature found! |
|
@jbdeboer can you please rebase and merge this one in? |
Add whitespace handling to the TestBed’s compile function. Closes dart-archive#1262. Previously, strings passed with leading or trailing whitespace would be compiled incorrectly. Now, valid HTML with arbitrary whitespace in and surrounding it can be compiled properly. Closes dart-archive#1346
|
I have https://travis-ci.org/jbdeboer/angular.dart/builds/33932643 which looks good. I will run final tests tomorrow. |
chirayuk
force-pushed
the
master
branch
2 times, most recently
from
8fd235c to
50e2645
Compare
Add whitespace handling to the TestBed’s compile function. Closes dart-archive#1262. Previously, strings passed with leading or trailing whitespace would be compiled incorrectly. Now, valid HTML with arbitrary whitespace in and surrounding it can be compiled properly. Closes dart-archive#1346
Add whitespace handling to the TestBed’s compile function. Closes dart-archive#1262. Previously, strings passed with leading or trailing whitespace would be compiled incorrectly. Now, valid HTML with arbitrary whitespace in and surrounding it can be compiled properly. Closes dart-archive#1346
Add whitespace handling to the TestBed’s compile function.
Closes #1262. Previously, strings passed with leading or
trailing whitespace would be compiled incorrectly. Now,
valid HTML with arbitrary whitespace in and surrounding it
can be compiled properly.