Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Don't share resolvers between parallel transformers as this will cause a deadlock #1382

Closed
wants to merge 1 commit into from

Conversation

taisph
Copy link
Contributor

@taisph taisph commented Aug 22, 2014

fixes #1276
closes #1382

@mhevery
Copy link
Contributor

mhevery commented Aug 22, 2014

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form): http://code.google.com/legal/individual-cla-v1.0.html

@mhevery mhevery added cla: no and removed cla: yes labels Aug 22, 2014
@taisph
Copy link
Contributor Author

taisph commented Aug 22, 2014

@mhevery Signed again... Did it go through this time?

@vicb
Copy link
Contributor

vicb commented Aug 22, 2014

LGTM

@taisph all that time for such a little change !

I'm kidding that's awesome, thank you so much.

you need to sign the CLA with the email used for this commit (taishansen at gmail).

Could you please also update the commit comment
Refs angular/angular.dart#1276. ->

fixes #1276
closes #1382

(We often put the fixes part only but as you know the PR# and edit the msg, please also add the closes part)

@taisph
Copy link
Contributor Author

taisph commented Aug 22, 2014

@vicb It is really insane so much code and debugging I had to go through to get to this ridiculously simple solution.

As noted, I signed the CLA again, using the mentioned email address which is the one used in the commit. I really don't know why you don't see it (if that's the case again).

I updated the PR comment here. I'm unsure if you actually meant the original commit message?

@jbdeboer
Copy link
Contributor

@taisph Yes, I see the CLA in our database, the Github tool has not picked it up yet. This PR is good to merge.

Bonus points for a test, though !

@jbdeboer jbdeboer added cla: yes and removed cla: no labels Aug 22, 2014
jbdeboer pushed a commit that referenced this pull request Aug 22, 2014
jbdeboer pushed a commit that referenced this pull request Aug 22, 2014
@vicb
Copy link
Contributor

vicb commented Aug 22, 2014

I'm unsure if you actually meant the original commit message ?

yep I was referring to the original commit message

@jbdeboer jbdeboer closed this in dba6727 Aug 22, 2014
dsalsbury added a commit to dsalsbury/angular.dart that referenced this pull request Aug 25, 2014
… as this will cause a deadlock

Fixes dart-archive#1276
Closes dart-archive#1382

Conflicts:
	lib/transformer.dart
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

pub serve hangs forever after code change on 0.13.0
4 participants