Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Ship with a reasonable MirrorUsed for angularDart #409

Closed
mhevery opened this issue Jan 10, 2014 · 9 comments
Closed

Ship with a reasonable MirrorUsed for angularDart #409

mhevery opened this issue Jan 10, 2014 · 9 comments
Milestone

Comments

@mhevery
Copy link
Contributor

mhevery commented Jan 10, 2014

No description provided.

@ghost ghost assigned jbdeboer Jan 10, 2014
@sethladd
Copy link
Contributor

/sub

@jbdeboer
Copy link
Contributor

Work involved:
-> add our "best known" list of mirrors near ngBootstrap.
-> verify that new directives can be added without needed to update the list
-> document how and when apps need to provide additional MirrorsUsed.
-> verify that apps which provide their own list of mirrors don't break

@sethladd
Copy link
Contributor

@shailen
Copy link

shailen commented Jan 24, 2014

Kasper Lund landed a commit (https://codereview.chromium.org//137953002) that added the MirrorsUsed declaration to the todo sample in the dart repo. See:

https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/samples/third_party/angular_todo/main.dart

This can serve as a useful guide for what Angular should automatically ship with so there is no need for every app to add Angular-specific MirrorsUsed metadata.

jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jan 24, 2014
@mhevery
Copy link
Contributor Author

mhevery commented Jan 26, 2014

very nice

@mhevery
Copy link
Contributor Author

mhevery commented Jan 26, 2014

@jbdeboer do you have numbers as to how big hello world app is now?

jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jan 28, 2014
@ufoscout
Copy link

@mhevery the current size of angular hello world app is around 800kb. It is not so small :(
Are there additional optimisation of this aspect planned? Am I wrong or I read somewhere that there are plans to not use mirrors at all in a future version?

@TedSander
Copy link
Contributor

There are Transformers now which remove the need for mirrors used. It creates static code for all the locations that used Mirrors. See: https://github.com/angular/angular.dart/blob/master/lib/transformer.dart for the transformers.

This lowers the code size, and speeds up the application.

@mhevery
Copy link
Contributor Author

mhevery commented May 1, 2014

@ufoscout The current hello world size after gzip is around 200kb. I don't think we can get it much smaller.

https://github.com/angular/angular.dart/blob/master/scripts/travis/build.sh#L47

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

6 participants