Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

fix(ngShow): Add/remove ng-hide class instead of ng-show class #521

Closed
wants to merge 1 commit into from
Closed

fix(ngShow): Add/remove ng-hide class instead of ng-show class #521

wants to merge 1 commit into from

Conversation

bgourlie
Copy link
Contributor

@bgourlie bgourlie commented Feb 6, 2014

fixes #518

@vicb
Copy link
Contributor

vicb commented Feb 7, 2014

LGTM, @bgourlie could please reword your commits as per CONTRIBUTING.md - and maybe squash the 3 commits.

@bgourlie
Copy link
Contributor Author

bgourlie commented Feb 7, 2014

@vicb Done! I'd never done a rebase after having pushed something to github, so that was a nice learning experience!

@vicb
Copy link
Contributor

vicb commented Feb 7, 2014

thanks, conflicts ?

@bgourlie
Copy link
Contributor Author

bgourlie commented Feb 7, 2014

Not sure what you're trying to ask...

@vicb
Copy link
Contributor

vicb commented Feb 7, 2014

Just asking if git conflicts were part of your "nice learning xp"

@bgourlie
Copy link
Contributor Author

bgourlie commented Feb 7, 2014

Oh, gotcha. Everything went smoothly. I was under the impression that it wasn't possible to rebase once commits have been pushed back to github. It's a good thing to know!

@mhevery mhevery self-assigned this Feb 11, 2014
@mhevery mhevery closed this in 0b88d2e Feb 12, 2014
@alexm77
Copy link

alexm77 commented Feb 20, 2014

It is technically possible to force push after publishing your branch, however this is strongly discouraged. It's mostly ok for a branch you know no one else touches, but if you were to branch off someone else's branch and then they did a force push, you'd be screwed, because your branching commit would be gone.
Technicalities aside, thanks for taking the time to fix this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

NgShow should be adding or removing the ng-hide class, not ng-show
4 participants