This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
feat(ngModel): Treat the values of number and range inputs as numbers #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a InputNumberLikeDirective that binds the model as a numeric value, so that it can be bound to num types on scopes. Select the directive for number and range input types.
|
I was getting type errors when trying to bind a numeric value on a controller to an input type="number". It was coming back as a String, and that was because it was handled by InputTextLikeDirective. Also, input type="range" was not being handled at all. This commit adds a new InputNumberLikeDirective for those input types. |
mhevery
pushed a commit
to mhevery/angular.dart
that referenced
this pull request
Feb 11, 2014
Add a InputNumberLikeDirective that binds the model as a numeric value, so that it can be bound to num types on scopes. Select the directive for number and range input types. Closes dart-archive#527
mhevery
pushed a commit
to mhevery/angular.dart
that referenced
this pull request
Feb 15, 2014
Updating analyzer version to 0.11 Updated analyzer has a number of convenience methods that make it easier with code gen. No code changes needed. Closes dart-archive#527
mhevery
pushed a commit
to mhevery/angular.dart
that referenced
this pull request
Feb 15, 2014
Updating analyzer version to 0.11 Updated analyzer has a number of convenience methods that make it easier with code gen. No code changes needed. Closes dart-archive#527
mhevery
pushed a commit
to mhevery/angular.dart
that referenced
this pull request
Feb 19, 2014
…g valueAsNumber Closes dart-archive#574, Closes dart-archive#575, Closes dart-archive#576. Previous patches of relevance: dart-archive#527, dart-archive#415 Closes dart-archive#577
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a InputNumberLikeDirective that binds the model as a numeric
value, so that it can be bound to num types on scopes. Select the
directive for number and range input types.