This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
fix(scope): should allow removing listener during an event #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -736,6 +736,9 @@ class ScopeStream extends async.Stream<ScopeEvent> { | |||
| final _Streams _streams; | |||
| final String _name; | |||
| final subscriptions = <ScopeStreamSubscription>[]; | |||
| bool _firing = false; | |||
| List<ScopeStreamSubscription> _toRemove; | |||
There was a problem hiding this comment.
@pavelgj out of curiosity, why have you picked a lazy init here ? (the code could be simpler at the expense of some bytes)
There was a problem hiding this comment.
Trying to avoid unnecessary allocations to handle a corner case.
There was a problem hiding this comment.
would it be a good use case for introducing a getter ?
There was a problem hiding this comment.
The way I imagine a getter here it would also result in an unnecessary allocation when _remove is never called. How would you do it?
There was a problem hiding this comment.
You're absolutely right. I must be tired, I've just lost half a day fixing my ubuntu setup...
pavelgj
added a commit
that referenced
this pull request
Mar 12, 2014
pavelgj
added a commit
that referenced
this pull request
Mar 12, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.