This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
feat(AstParser): Made the AST parser private to the scope #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes dart-archive#755 Ad support for '"s" + ("m"|filter) + "e"'
relates to "[Scope] Issue with scope.unwatch() not working dart-archive#787" The test is disabled because of GH dart-archive#787. The bug existed before this PR but what only not triggered. The usage of the stringify filter do trigger the bug.
vicb
added a commit
to vicb/angular.dart
that referenced
this pull request
Mar 31, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #758 - clean & rebased version.
FilterMaprequired. I only took care to propagate the filters everywhere,xita test for Travis to be happy because of [Scope] Issue with scope.unwatch() not working #787I think this PR is good enough to be merged asap. I won't be able to work on it next week (on vacation) but I can polish the first two items when I'm back.