fix(filterFilter): do not throw an error if property is null when comparing objects

Closes #10991
Closes #10992
Closes #11116

Author: ElephantRose

src/ng/filter/filter.js

@@ -181,8 +181,8 @@ function createPredicateFn(expression, comparator, matchAgainstAnyProp) {
 }
 
 function deepCompare(actual, expected, comparator, matchAgainstAnyProp, dontMatchWholeObject) {
-  var actualType = typeof actual;
-  var expectedType = typeof expected;
+  var actualType = (actual !== null) ? typeof actual : 'null';
+  var expectedType = (expected !== null) ? typeof expected : 'null';
 
   if ((expectedType === 'string') && (expected.charAt(0) === '!')) {
     return !deepCompare(actual, expected.substring(1), comparator, matchAgainstAnyProp);

test/ng/filter/filterSpec.js

@@ -399,6 +399,33 @@ describe('Filter: filter', function() {
   });
 
 
+  it('should not throw an error if property is null when comparing object', function() {
+      var items = [
+          { office:1, people: {name:'john'}},
+          { office:2, people: {name:'jane'}},
+          { office:3, people: null}
+      ];
+      var f = { };
+      expect(filter(items, f).length).toBe(3);
+
+      f = { people:null };
+      expect(filter(items, f).length).toBe(1);
+
+      f = { people: {}};
+      expect(filter(items, f).length).toBe(2);
+
+      f = { people:{ name: '' }};
+      expect(filter(items, f).length).toBe(2);
+
+      f = { people:{ name:'john' }};
+      expect(filter(items, f).length).toBe(1);
+
+      f = { people:{ name:'j' }};
+      expect(filter(items, f).length).toBe(2);
+
+  });
+
+
   describe('should support comparator', function() {
 
     it('not consider `object === "[object Object]"` in non-strict comparison', function() {