Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 2e61446

Browse files
rodyhaddadrodyhaddad
committed
style(parseSpec): make jshint happy
1 parent 77ada4c commit 2e61446

File tree

1 file changed

+74
-44
lines changed

1 file changed

+74
-44
lines changed

‎test/ng/parseSpec.js

+74-44
Original file line numberDiff line numberDiff line change
@@ -700,13 +700,13 @@ describe('parser', function() {
700700
scope.fn = Function.prototype.call;
701701

702702
expect(function() {
703-
scope.$eval('$eval.call()')
703+
scope.$eval('$eval.call()');
704704
}).toThrowMinErr(
705705
'$parse', 'isecff', 'Referencing call, apply or bind in Angular expressions is disallowed! ' +
706706
'Expression: $eval.call()');
707707

708708
expect(function() {
709-
scope.$eval('fn()')
709+
scope.$eval('fn()');
710710
}).toThrowMinErr(
711711
'$parse', 'isecff', 'Referencing call, apply or bind in Angular expressions is disallowed! ' +
712712
'Expression: fn()');
@@ -716,13 +716,13 @@ describe('parser', function() {
716716
scope.apply = Function.prototype.apply;
717717

718718
expect(function() {
719-
scope.$eval('$eval.apply()')
719+
scope.$eval('$eval.apply()');
720720
}).toThrowMinErr(
721721
'$parse', 'isecff', 'Referencing call, apply or bind in Angular expressions is disallowed! ' +
722722
'Expression: $eval.apply()');
723723

724724
expect(function() {
725-
scope.$eval('apply()')
725+
scope.$eval('apply()');
726726
}).toThrowMinErr(
727727
'$parse', 'isecff', 'Referencing call, apply or bind in Angular expressions is disallowed! ' +
728728
'Expression: apply()');
@@ -732,13 +732,13 @@ describe('parser', function() {
732732
scope.bind = Function.prototype.bind;
733733

734734
expect(function() {
735-
scope.$eval('$eval.bind()')
735+
scope.$eval('$eval.bind()');
736736
}).toThrowMinErr(
737737
'$parse', 'isecff', 'Referencing call, apply or bind in Angular expressions is disallowed! ' +
738738
'Expression: $eval.bind()');
739739

740740
expect(function() {
741-
scope.$eval('bind()')
741+
scope.$eval('bind()');
742742
}).toThrowMinErr(
743743
'$parse', 'isecff', 'Referencing call, apply or bind in Angular expressions is disallowed! ' +
744744
'Expression: bind()');
@@ -836,98 +836,128 @@ describe('parser', function() {
836836

837837
describe('Disallowed fields', function() {
838838
it('should NOT allow access or invocation of __defineGetter__', function() {
839-
expect(function() {
840-
scope.$eval('{}.__defineGetter__'); }).toThrowMinErr('$parse', 'isecfld');
841-
expect(function() {
842-
scope.$eval('{}.__defineGetter__("a", "".charAt)'); }).toThrowMinErr('$parse', 'isecfld');
839+
expect(function() {
840+
scope.$eval('{}.__defineGetter__');
841+
}).toThrowMinErr('$parse', 'isecfld');
842+
expect(function() {
843+
scope.$eval('{}.__defineGetter__("a", "".charAt)');
844+
}).toThrowMinErr('$parse', 'isecfld');
843845

844-
expect(function() {
845-
scope.$eval('{}["__defineGetter__"]'); }).toThrowMinErr('$parse', 'isecfld');
846-
expect(function() {
847-
scope.$eval('{}["__defineGetter__"]("a", "".charAt)'); }).toThrowMinErr('$parse', 'isecfld');
846+
expect(function() {
847+
scope.$eval('{}["__defineGetter__"]');
848+
}).toThrowMinErr('$parse', 'isecfld');
849+
expect(function() {
850+
scope.$eval('{}["__defineGetter__"]("a", "".charAt)');
851+
}).toThrowMinErr('$parse', 'isecfld');
848852

849853
scope.a = "__define";
850854
scope.b = "Getter__";
851-
expect(function() {
852-
scope.$eval('{}[a + b]'); }).toThrowMinErr('$parse', 'isecfld');
853-
expect(function() {
854-
scope.$eval('{}[a + b]("a", "".charAt)'); }).toThrowMinErr('$parse', 'isecfld');
855+
expect(function() {
856+
scope.$eval('{}[a + b]');
857+
}).toThrowMinErr('$parse', 'isecfld');
858+
expect(function() {
859+
scope.$eval('{}[a + b]("a", "".charAt)');
860+
}).toThrowMinErr('$parse', 'isecfld');
855861
});
856862

857863
it('should NOT allow access or invocation of __defineSetter__', function() {
858864
expect(function() {
859-
scope.$eval('{}.__defineSetter__'); }).toThrowMinErr('$parse', 'isecfld');
865+
scope.$eval('{}.__defineSetter__');
866+
}).toThrowMinErr('$parse', 'isecfld');
860867
expect(function() {
861-
scope.$eval('{}.__defineSetter__("a", "".charAt)'); }).toThrowMinErr('$parse', 'isecfld');
868+
scope.$eval('{}.__defineSetter__("a", "".charAt)');
869+
}).toThrowMinErr('$parse', 'isecfld');
862870

863871
expect(function() {
864-
scope.$eval('{}["__defineSetter__"]'); }).toThrowMinErr('$parse', 'isecfld');
872+
scope.$eval('{}["__defineSetter__"]');
873+
}).toThrowMinErr('$parse', 'isecfld');
865874
expect(function() {
866-
scope.$eval('{}["__defineSetter__"]("a", "".charAt)'); }).toThrowMinErr('$parse', 'isecfld');
875+
scope.$eval('{}["__defineSetter__"]("a", "".charAt)');
876+
}).toThrowMinErr('$parse', 'isecfld');
867877

868878
scope.a = "__define";
869879
scope.b = "Setter__";
870880
expect(function() {
871-
scope.$eval('{}[a + b]'); }).toThrowMinErr('$parse', 'isecfld');
881+
scope.$eval('{}[a + b]');
882+
}).toThrowMinErr('$parse', 'isecfld');
872883
expect(function() {
873-
scope.$eval('{}[a + b]("a", "".charAt)'); }).toThrowMinErr('$parse', 'isecfld');
884+
scope.$eval('{}[a + b]("a", "".charAt)');
885+
}).toThrowMinErr('$parse', 'isecfld');
874886
});
875887

876888
it('should NOT allow access or invocation of __lookupGetter__', function() {
877889
expect(function() {
878-
scope.$eval('{}.__lookupGetter__'); }).toThrowMinErr('$parse', 'isecfld');
890+
scope.$eval('{}.__lookupGetter__');
891+
}).toThrowMinErr('$parse', 'isecfld');
879892
expect(function() {
880-
scope.$eval('{}.__lookupGetter__("a")'); }).toThrowMinErr('$parse', 'isecfld');
893+
scope.$eval('{}.__lookupGetter__("a")');
894+
}).toThrowMinErr('$parse', 'isecfld');
881895

882896
expect(function() {
883-
scope.$eval('{}["__lookupGetter__"]'); }).toThrowMinErr('$parse', 'isecfld');
897+
scope.$eval('{}["__lookupGetter__"]');
898+
}).toThrowMinErr('$parse', 'isecfld');
884899
expect(function() {
885-
scope.$eval('{}["__lookupGetter__"]("a")'); }).toThrowMinErr('$parse', 'isecfld');
900+
scope.$eval('{}["__lookupGetter__"]("a")');
901+
}).toThrowMinErr('$parse', 'isecfld');
886902

887903
scope.a = "__lookup";
888904
scope.b = "Getter__";
889905
expect(function() {
890-
scope.$eval('{}[a + b]'); }).toThrowMinErr('$parse', 'isecfld');
906+
scope.$eval('{}[a + b]');
907+
}).toThrowMinErr('$parse', 'isecfld');
891908
expect(function() {
892-
scope.$eval('{}[a + b]("a")'); }).toThrowMinErr('$parse', 'isecfld');
909+
scope.$eval('{}[a + b]("a")');
910+
}).toThrowMinErr('$parse', 'isecfld');
893911
});
894912

895913
it('should NOT allow access or invocation of __lookupSetter__', function() {
896914
expect(function() {
897-
scope.$eval('{}.__lookupSetter__'); }).toThrowMinErr('$parse', 'isecfld');
915+
scope.$eval('{}.__lookupSetter__');
916+
}).toThrowMinErr('$parse', 'isecfld');
898917
expect(function() {
899-
scope.$eval('{}.__lookupSetter__("a")'); }).toThrowMinErr('$parse', 'isecfld');
918+
scope.$eval('{}.__lookupSetter__("a")');
919+
}).toThrowMinErr('$parse', 'isecfld');
900920

901921
expect(function() {
902-
scope.$eval('{}["__lookupSetter__"]'); }).toThrowMinErr('$parse', 'isecfld');
922+
scope.$eval('{}["__lookupSetter__"]');
923+
}).toThrowMinErr('$parse', 'isecfld');
903924
expect(function() {
904-
scope.$eval('{}["__lookupSetter__"]("a")'); }).toThrowMinErr('$parse', 'isecfld');
925+
scope.$eval('{}["__lookupSetter__"]("a")');
926+
}).toThrowMinErr('$parse', 'isecfld');
905927

906928
scope.a = "__lookup";
907929
scope.b = "Setter__";
908930
expect(function() {
909-
scope.$eval('{}[a + b]'); }).toThrowMinErr('$parse', 'isecfld');
931+
scope.$eval('{}[a + b]');
932+
}).toThrowMinErr('$parse', 'isecfld');
910933
expect(function() {
911-
scope.$eval('{}[a + b]("a")'); }).toThrowMinErr('$parse', 'isecfld');
934+
scope.$eval('{}[a + b]("a")');
935+
}).toThrowMinErr('$parse', 'isecfld');
912936
});
913937

914938
it('should NOT allow access to __proto__', function() {
915939
expect(function() {
916-
scope.$eval('{}.__proto__'); }).toThrowMinErr('$parse', 'isecfld');
940+
scope.$eval('{}.__proto__');
941+
}).toThrowMinErr('$parse', 'isecfld');
917942
expect(function() {
918-
scope.$eval('{}.__proto__.foo = 1'); }).toThrowMinErr('$parse', 'isecfld');
943+
scope.$eval('{}.__proto__.foo = 1');
944+
}).toThrowMinErr('$parse', 'isecfld');
919945

920946
expect(function() {
921-
scope.$eval('{}["__proto__"]'); }).toThrowMinErr('$parse', 'isecfld');
947+
scope.$eval('{}["__proto__"]');
948+
}).toThrowMinErr('$parse', 'isecfld');
922949
expect(function() {
923-
scope.$eval('{}["__proto__"].foo = 1'); }).toThrowMinErr('$parse', 'isecfld');
950+
scope.$eval('{}["__proto__"].foo = 1');
951+
}).toThrowMinErr('$parse', 'isecfld');
924952

925953
scope.a = "__pro";
926954
scope.b = "to__";
927955
expect(function() {
928-
scope.$eval('{}[a + b]'); }).toThrowMinErr('$parse', 'isecfld');
956+
scope.$eval('{}[a + b]');
957+
}).toThrowMinErr('$parse', 'isecfld');
929958
expect(function() {
930-
scope.$eval('{}[a + b].foo = 1'); }).toThrowMinErr('$parse', 'isecfld');
959+
scope.$eval('{}[a + b].foo = 1');
960+
}).toThrowMinErr('$parse', 'isecfld');
931961
});
932962
});
933963

@@ -939,9 +969,9 @@ describe('parser', function() {
939969
'null,' +
940970
'"alert(1)"' +
941971
')()' +
942-
'')
972+
'');
943973
}).toThrow();
944-
})
974+
});
945975
});
946976

947977
it('should call the function from the received instance and not from a new one', function() {

0 commit comments

Comments
 (0)