Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 4ae3873

Browse files
committed
fix($compile): change directive name validation error entry
As angular team suggested, it's better use 'baddir' error entry for whitespace validation. Closes #11397
1 parent 974ccdd commit 4ae3873

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/ng/compile.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -803,7 +803,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
803803
throw $compileMinErr('baddir', "Directive name '{0}' is invalid. The first character must be a lowercase letter", name);
804804
}
805805
if (name !== name.trim()) {
806-
throw $compileMinErr('baddirwspc',
806+
throw $compileMinErr('baddir',
807807
"Directive name '{0}' is invalid. The name should not contain leading or trailing whitespaces",
808808
name);
809809
}

test/ng/compileSpec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ describe('$compile', function() {
217217
expect(function() {
218218
directive(name, function() { });
219219
}).toThrowMinErr(
220-
'$compile','baddirwspc', 'Directive name \'' + name + '\' is invalid. ' +
220+
'$compile','baddir', 'Directive name \'' + name + '\' is invalid. ' +
221221
"The name should not contain leading or trailing whitespaces");
222222
}
223223
assertLeadingOrTrailingWhitespaceInDirectiveName(' leadingWhitespaceDirectiveName');

0 commit comments

Comments
 (0)