Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 4daafd3

Browse files
committedNov 3, 2015
perf(merge): remove unnecessary wrapping of jqLite element
Fixes 75292a6#commitcomment-14137538 Closes #13236
1 parent fe11265 commit 4daafd3

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed
 

‎src/Angular.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ function baseExtend(dst, objs, deep) {
363363
} else if (src.nodeName) {
364364
dst[key] = src.cloneNode(true);
365365
} else if (isElement(src)) {
366-
dst[key] = jqLite(src).clone();
366+
dst[key] = src.clone();
367367
} else {
368368
if (!isObject(dst[key])) dst[key] = isArray(src) ? [] : {};
369369
baseExtend(dst[key], [src], true);

‎test/AngularSpec.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -639,8 +639,10 @@ describe('angular', function() {
639639

640640

641641
it('should copy(clone) elements', function() {
642-
var src = { element: document.createElement('div'),
643-
jqObject: jqLite("<p><span>s1</span><span>s2</span></p>").find("span") };
642+
var src = {
643+
element: document.createElement('div'),
644+
jqObject: jqLite('<p><span>s1</span><span>s2</span></p>').find('span')
645+
};
644646
var dst = {};
645647

646648
merge(dst, src);
@@ -651,7 +653,7 @@ describe('angular', function() {
651653
expect(isElement(dst.element)).toBeTruthy();
652654
expect(dst.element.nodeName).toBeDefined(); // i.e it is a DOM element
653655
expect(isElement(dst.jqObject)).toBeTruthy();
654-
expect(dst.jqObject.nodeName).toBeUndefined(dst.jqObject); // i.e it is a jqLite/jquery object
656+
expect(dst.jqObject.nodeName).toBeUndefined(); // i.e it is a jqLite/jQuery object
655657
});
656658
});
657659

0 commit comments

Comments
 (0)
This repository has been archived.