Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 622c3ec

Browse files
committedSep 1, 2011
fix(jqLite): addClass should ignore falsy values
1 parent db78aa1 commit 622c3ec

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed
 

‎src/jqLite.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,8 @@ function JQLiteRemoveClass(element, selector) {
162162
);
163163
}
164164

165-
function JQLiteAddClass(element, selector ) {
166-
if (!JQLiteHasClass(element, selector)) {
165+
function JQLiteAddClass(element, selector) {
166+
if (selector && !JQLiteHasClass(element, selector)) {
167167
element.className = trim(element.className + ' ' + selector);
168168
}
169169
}

‎test/jqLiteSpec.js

+14
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,20 @@ describe('jqLite', function(){
197197
expect(jqLite(a).hasClass('abc')).toEqual(true);
198198
expect(jqLite(b).hasClass('abc')).toEqual(true);
199199
});
200+
201+
it('should ignore falsy values', function() {
202+
var jqA = jqLite(a);
203+
expect(jqA[0].className).toBe('');
204+
205+
jqA.addClass(undefined);
206+
expect(jqA[0].className).toBe('');
207+
208+
jqA.addClass(null);
209+
expect(jqA[0].className).toBe('');
210+
211+
jqA.addClass(false);
212+
expect(jqA[0].className).toBe('');
213+
});
200214
});
201215

202216

0 commit comments

Comments
 (0)
This repository has been archived.