Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 6b12fa3

Browse files
committed
chore(ci): avoid deploying if linting fails
Previously, the `prepare-deployment` CI job, which requires all unit and e2e test jobs to have succeeded before running, was ignoring the `lint` job. As a result, deployments might happen even when there were linting issues. This looks like an oversight. This commit ensures that, in addition to unit and e2e tests passing, linting must also pass before deploying the code or documentation.
1 parent 6c5918b commit 6b12fa3

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.circleci/config.yml

+1
Original file line numberDiff line numberDiff line change
@@ -436,6 +436,7 @@ workflows:
436436
<<: *run-on-tags-and-master-and-version-branches
437437
requires:
438438
- setup
439+
- lint
439440
- unit-test
440441
- unit-test-jquery
441442
- e2e-test-1

0 commit comments

Comments
 (0)