Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit a070ff5

Browse files
committed
make all built-in services lazy
now that we require DI everywhere, we don't need any of these services to be eager - they get initialized when and only when they are requested.
1 parent c90abf0 commit a070ff5

File tree

7 files changed

+6
-8
lines changed

7 files changed

+6
-8
lines changed

src/service/defer.js

-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
* @param {function()} fn A function, who's execution should be deferred.
1717
*/
1818
angularServiceInject('$defer', function($browser, $exceptionHandler, $updateView) {
19-
var scope = this;
20-
2119
return function(fn) {
2220
$browser.defer(function() {
2321
try {

src/service/document.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@
1010
*/
1111
angularServiceInject("$document", function(window){
1212
return jqLite(window.document);
13-
}, ['$window'], true);
13+
}, ['$window']);

src/service/exceptionHandler.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ angularServiceInject('$exceptionHandler', $exceptionHandlerFactory = function($l
1919
return function(e) {
2020
$log.error(e);
2121
};
22-
}, ['$log'], true);
22+
}, ['$log']);

src/service/hover.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,4 +53,4 @@ angularServiceInject("$hover", function(browser, document) {
5353
tooltip = _null;
5454
}
5555
});
56-
}, ['$browser', '$document'], true);
56+
}, ['$browser', '$document']);

src/service/invalidWidgets.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,4 +64,4 @@ angularServiceInject("$invalidWidgets", function(){
6464
}
6565

6666
return invalidWidgets;
67-
}, [], true);
67+
});

src/service/log.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,4 +89,4 @@ angularServiceInject("$log", $logFactory = function($window){
8989
return logFn;
9090
}
9191
}
92-
}, ['$window'], true);
92+
}, ['$window']);

src/service/window.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@
2222
</doc:scenario>
2323
</doc:example>
2424
*/
25-
angularServiceInject("$window", bind(window, identity, window), [], true);
25+
angularServiceInject("$window", bind(window, identity, window));

0 commit comments

Comments
 (0)