Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit b1a43cd

Browse files
matskomhevery
authored andcommitted
fix($sniffer): ensure older versions of webkit work for animations
1 parent b7a5449 commit b1a43cd

File tree

2 files changed

+38
-0
lines changed

2 files changed

+38
-0
lines changed

src/ng/sniffer.js

+5
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ function $SnifferProvider() {
3535
break;
3636
}
3737
}
38+
39+
if(!vendorPrefix) {
40+
vendorPrefix = ('WebkitOpacity' in bodyStyle) && 'webkit';
41+
}
42+
3843
transitions = !!(('transition' in bodyStyle) || (vendorPrefix + 'Transition' in bodyStyle));
3944
animations = !!(('animation' in bodyStyle) || (vendorPrefix + 'Animation' in bodyStyle));
4045

test/ng/snifferSpec.js

+33
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,22 @@ describe('$sniffer', function() {
122122
});
123123
});
124124

125+
it('should still work for an older version of Webkit', function() {
126+
module(function($provide) {
127+
var doc = {
128+
body : {
129+
style : {
130+
WebkitOpacity: '0'
131+
}
132+
}
133+
};
134+
$provide.value('$document', jqLite(doc));
135+
});
136+
inject(function($sniffer) {
137+
expect($sniffer.vendorPrefix).toBe('webkit');
138+
});
139+
});
140+
125141
});
126142

127143
describe('animations', function() {
@@ -201,6 +217,23 @@ describe('$sniffer', function() {
201217
expect($sniffer.animations).toBe(true);
202218
});
203219
});
220+
221+
it('should be true when an older version of Webkit is used', function() {
222+
module(function($provide) {
223+
var doc = {
224+
body : {
225+
style : {
226+
WebkitOpacity: '0'
227+
}
228+
}
229+
};
230+
$provide.value('$document', jqLite(doc));
231+
});
232+
inject(function($sniffer) {
233+
expect($sniffer.animations).toBe(false);
234+
});
235+
});
236+
204237
});
205238

206239
describe('transitions', function() {

0 commit comments

Comments
 (0)