Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit bcbc7e5

Browse files
committed
chore(ngAnimate): add TODO messages indicating desire to remove hack
1 parent c966b2f commit bcbc7e5

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

src/ng/animate.js

+2
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,8 @@ var $AnimateProvider = ['$provide', function($provide) {
289289
element = jqLite(element);
290290

291291
if (runSynchronously) {
292+
// TODO(@caitp/@matsko): Remove undocumented `runSynchronously` parameter, and always
293+
// perform DOM manipulation asynchronously or in postDigest.
292294
self.$$addClassImmediately(element, add);
293295
self.$$removeClassImmediately(element, remove);
294296
return asyncPromise();

src/ngAnimate/animate.js

+3
Original file line numberDiff line numberDiff line change
@@ -979,6 +979,9 @@ angular.module('ngAnimate', ['ng'])
979979
element = stripCommentsFromElement(element);
980980

981981
if (classBasedAnimationsBlocked(element)) {
982+
// TODO(@caitp/@matsko): Don't use private/undocumented API here --- we should not be
983+
// changing the DOM synchronously in this case. The `true` parameter must eventually be
984+
// removed.
982985
return $delegate.setClass(element, add, remove, true);
983986
}
984987

0 commit comments

Comments
 (0)