Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit cbe31d8

Browse files
IgorMinarbtford
authored andcommitted
fix($location): default to / for the url base if no base[href]
With the recent refactoring of $location service we changed this behavior resulting in a regression. Previously we thought that html5 mode always required base[href] to be set in order for urls to resolve properly. It turns out that base[href] is problematic because it makes anchor urls (#foo) to always resolve to the base url, which is almost always incorrect and results in all anchors links and other anchor urls (e.g. svg references) to be broken. For this reason, we should now start recommending that people just deploy to root context (/) and not set the base[href] when using the html5 mode (push/pop history state). If it's impossible to deploy to the root context then either all urls in the app must be absolute or base[href] must be set with the caveat that anchor urls in such app won't work. Closes #2762
1 parent 06b0930 commit cbe31d8

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

test/ng/locationSpec.js

+13
Original file line numberDiff line numberDiff line change
@@ -610,6 +610,19 @@ describe('$location', function() {
610610
}
611611
);
612612
});
613+
614+
615+
it('should set appBase to serverBase if base[href] is missing', function() {
616+
initService(true, '!', true);
617+
inject(
618+
initBrowser('http://domain.com/my/view1#anchor1', ''),
619+
function($rootScope, $location, $browser) {
620+
expect($browser.url()).toBe('http://domain.com/my/view1#anchor1');
621+
expect($location.path()).toBe('/my/view1');
622+
expect($location.hash()).toBe('anchor1');
623+
}
624+
);
625+
});
613626
});
614627

615628

0 commit comments

Comments
 (0)