refactor($compile): remove safeAddClass

This helper function does try/catch in case the element is an SVG element. jqLite does handle this properly (because it uses `setAttribute`. jQuery does not handle this and so we need to make sure we use `jqLiteAddClass` function.

Author: vojtajina

src/ng/compile.js

@@ -887,16 +887,6 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
     };
 
 
-    function safeAddClass($element, className) {
-      try {
-        $element.addClass(className);
-      } catch(e) {
-        // ignore, since it means that we are trying to set class on
-        // SVG element, where class name is read-only.
-      }
-    }
-
-
     var startSymbol = $interpolate.startSymbol(),
         endSymbol = $interpolate.endSymbol(),
         denormalizeTemplate = (startSymbol == '{{' || endSymbol  == '}}')
@@ -919,7 +909,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
     } : noop;
 
     compile.$$addBindingClass = debugInfoEnabled ? function $$addBindingClass($element) {
-      safeAddClass($element, 'ng-binding');
+      jqLiteAddClass($element[0], 'ng-binding');
     } : noop;
 
     compile.$$addScopeInfo = debugInfoEnabled ? function $$addScopeInfo($element, scope, isolated, noTemplate) {
@@ -928,7 +918,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
     } : noop;
 
     compile.$$addScopeClass = debugInfoEnabled ? function $$addScopeClass($element, isolated) {
-      safeAddClass($element, isolated ? 'ng-isolate-scope' : 'ng-scope');
+      jqLiteAddClass($element[0], isolated ? 'ng-isolate-scope' : 'ng-scope');
     } : noop;
 
     return compile;
@@ -1842,7 +1832,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
       // copy the new attributes on the old attrs object
       forEach(src, function(value, key) {
         if (key == 'class') {
-          safeAddClass($element, value);
+          jqLiteAddClass($element[0], value);
           dst['class'] = (dst['class'] ? dst['class'] + ' ' : '') + value;
         } else if (key == 'style') {
           $element.attr('style', $element.attr('style') + ';' + value);
@@ -1941,7 +1931,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
               replaceWith(linkRootElement, jqLite(beforeTemplateLinkNode), linkNode);
 
               // Copy in CSS classes from original node
-              safeAddClass(jqLite(linkNode), oldClasses);
+              jqLiteAddClass(linkNode, oldClasses);
             }
             if (afterTemplateNodeLinkFn.transcludeOnThisElement) {
               childBoundTranscludeFn = createBoundTranscludeFn(scope, afterTemplateNodeLinkFn.transclude, boundTranscludeFn);