feat(ngMock): add they helpers for testing multiple specs

There are now three new test helpers: `they`, `tthey` and `xthey`, which
will create multiple `it`, `iit` and `xit` blocks, respectively, parameterized
by each item in a collection that is passed.

(with tests and ammendments by @petebacondarwin)

Closes #10864

Author: matsko

test/.jshintrc

@@ -143,6 +143,9 @@
     "waitsFor": false,
     "runs": false,
     "dump": false,
+    "they": false,
+    "tthey": false,
+    "xthey": false,
 
     /* e2e */
     "browser": false,

test/helpers/privateMocks.js

@@ -1,5 +1,34 @@
 'use strict';
 
+/* globals xit */
+
+function baseThey(msg, vals, spec, itFn) {
+  var valsIsArray = isArray(vals);
+
+  forEach(vals, function(val, key) {
+    var m = msg.replace('$prop', angular.toJson(valsIsArray ? val : key));
+    itFn(m, function() {
+      /* jshint -W040 : ignore possible strict violation due to use of this */
+      spec.call(this, val);
+    });
+  });
+}
+
+function they(msg, vals, spec) {
+  baseThey(msg, vals, spec, it);
+}
+
+function tthey(msg, vals, spec) {
+  baseThey(msg, vals, spec, iit);
+}
+
+function xthey(msg, vals, spec) {
+  /* jshint -W040 : ignore possible strict violation due to use of this */
+  baseThey(msg, vals, spec, xit);
+}
+
+
+
 function createMockStyleSheet(doc, wind) {
   doc = doc ? doc[0] : document;
   wind = wind || window;

test/helpers/privateMocksSpec.js

@@ -1,6 +1,196 @@
 'use strict';
 
 describe('private mocks', function() {
+
+  describe('Jasmine extensions', function() {
+
+    describe('they', function() {
+      it('should call `it` for each item in an array', function() {
+        spyOn(window, 'it');
+
+        they('should do stuff with $prop', ['a', 'b', 'c']);
+        expect(window.it.calls.length).toEqual(3);
+        expect(window.it).toHaveBeenCalledWith('should do stuff with "a"', jasmine.any(Function));
+        expect(window.it).toHaveBeenCalledWith('should do stuff with "b"', jasmine.any(Function));
+        expect(window.it).toHaveBeenCalledWith('should do stuff with "c"', jasmine.any(Function));
+      });
+
+
+      it('should pass each item in an array to the handler', function() {
+        var handlerSpy = jasmine.createSpy('handler');
+        spyOn(window, 'it').andCallFake(function(msg, handler) {
+          handler();
+        });
+        they('should do stuff with $prop', ['a', 'b', 'c'], handlerSpy);
+        expect(handlerSpy).toHaveBeenCalledWith('a');
+        expect(handlerSpy).toHaveBeenCalledWith('b');
+        expect(handlerSpy).toHaveBeenCalledWith('c');
+      });
+
+
+      it('should call `it` for each key-value pair an object', function() {
+        spyOn(window, 'it');
+
+        they('should do stuff with $prop', {a: 1, b:2, c:3});
+        expect(window.it.calls.length).toEqual(3);
+        expect(window.it).toHaveBeenCalledWith('should do stuff with "a"', jasmine.any(Function));
+        expect(window.it).toHaveBeenCalledWith('should do stuff with "b"', jasmine.any(Function));
+        expect(window.it).toHaveBeenCalledWith('should do stuff with "c"', jasmine.any(Function));
+      });
+
+
+      it('should pass each key-value pair in an object to the handler', function() {
+        var handlerSpy = jasmine.createSpy('handler');
+        spyOn(window, 'it').andCallFake(function(msg, handler) {
+          handler();
+        });
+        they('should do stuff with $prop', {a: 1, b:2, c:3}, handlerSpy);
+        expect(handlerSpy).toHaveBeenCalledWith(1);
+        expect(handlerSpy).toHaveBeenCalledWith(2);
+        expect(handlerSpy).toHaveBeenCalledWith(3);
+      });
+
+
+      it('should call handler with correct `this`', function() {
+        var handlerSpy = jasmine.createSpy('handler');
+        var dummyThis = { name: 'dummyThis' };
+
+        spyOn(window, 'it').andCallFake(function(msg, handler) {
+          handler.call(dummyThis);
+        });
+
+        they('should do stuff with $prop', ['a'], handlerSpy);
+        expect(window.it).toHaveBeenCalledWith('should do stuff with "a"', jasmine.any(Function));
+        expect(handlerSpy.mostRecentCall.object).toBe(dummyThis);
+      });
+    });
+
+
+    describe('tthey', function() {
+      it('should call `iit` for each item in an array', function() {
+        spyOn(window, 'iit');
+
+        tthey('should do stuff with $prop', ['a', 'b', 'c']);
+        expect(window.iit.calls.length).toEqual(3);
+        expect(window.iit).toHaveBeenCalledWith('should do stuff with "a"', jasmine.any(Function));
+        expect(window.iit).toHaveBeenCalledWith('should do stuff with "b"', jasmine.any(Function));
+        expect(window.iit).toHaveBeenCalledWith('should do stuff with "c"', jasmine.any(Function));
+      });
+
+
+      it('should pass each item in an array to the handler', function() {
+        var handlerSpy = jasmine.createSpy('handler');
+        spyOn(window, 'iit').andCallFake(function(msg, handler) {
+          handler();
+        });
+        tthey('should do stuff with $prop', ['a', 'b', 'c'], handlerSpy);
+        expect(handlerSpy).toHaveBeenCalledWith('a');
+        expect(handlerSpy).toHaveBeenCalledWith('b');
+        expect(handlerSpy).toHaveBeenCalledWith('c');
+      });
+
+
+      it('should call `it` for each key-value pair an object', function() {
+        spyOn(window, 'iit');
+
+        tthey('should do stuff with $prop', {a: 1, b:2, c:3});
+        expect(window.iit.calls.length).toEqual(3);
+        expect(window.iit).toHaveBeenCalledWith('should do stuff with "a"', jasmine.any(Function));
+        expect(window.iit).toHaveBeenCalledWith('should do stuff with "b"', jasmine.any(Function));
+        expect(window.iit).toHaveBeenCalledWith('should do stuff with "c"', jasmine.any(Function));
+      });
+
+
+      it('should pass each key-value pair in an object to the handler', function() {
+        var handlerSpy = jasmine.createSpy('handler');
+        spyOn(window, 'iit').andCallFake(function(msg, handler) {
+          handler();
+        });
+        tthey('should do stuff with $prop', {a: 1, b:2, c:3}, handlerSpy);
+        expect(handlerSpy).toHaveBeenCalledWith(1);
+        expect(handlerSpy).toHaveBeenCalledWith(2);
+        expect(handlerSpy).toHaveBeenCalledWith(3);
+      });
+
+
+      it('should call handler with correct `this`', function() {
+        var handlerSpy = jasmine.createSpy('handler');
+        var dummyThis = { name: 'dummyThis' };
+
+        spyOn(window, 'iit').andCallFake(function(msg, handler) {
+          handler.call(dummyThis);
+        });
+
+        tthey('should do stuff with $prop', ['a'], handlerSpy);
+        expect(window.iit).toHaveBeenCalledWith('should do stuff with "a"', jasmine.any(Function));
+        expect(handlerSpy.mostRecentCall.object).toBe(dummyThis);
+      });
+    });
+
+
+    describe('xthey', function() {
+      it('should call `xit` for each item in an array', function() {
+        spyOn(window, 'xit');
+
+        xthey('should do stuff with $prop', ['a', 'b', 'c']);
+        expect(window.xit.calls.length).toEqual(3);
+        expect(window.xit).toHaveBeenCalledWith('should do stuff with "a"', jasmine.any(Function));
+        expect(window.xit).toHaveBeenCalledWith('should do stuff with "b"', jasmine.any(Function));
+        expect(window.xit).toHaveBeenCalledWith('should do stuff with "c"', jasmine.any(Function));
+      });
+
+
+      it('should pass each item in an array to the handler', function() {
+        var handlerSpy = jasmine.createSpy('handler');
+        spyOn(window, 'xit').andCallFake(function(msg, handler) {
+          handler();
+        });
+        xthey('should do stuff with $prop', ['a', 'b', 'c'], handlerSpy);
+        expect(handlerSpy).toHaveBeenCalledWith('a');
+        expect(handlerSpy).toHaveBeenCalledWith('b');
+        expect(handlerSpy).toHaveBeenCalledWith('c');
+      });
+
+
+      it('should call `it` for each key-value pair an object', function() {
+        spyOn(window, 'xit');
+
+        xthey('should do stuff with $prop', {a: 1, b:2, c:3});
+        expect(window.xit.calls.length).toEqual(3);
+        expect(window.xit).toHaveBeenCalledWith('should do stuff with "a"', jasmine.any(Function));
+        expect(window.xit).toHaveBeenCalledWith('should do stuff with "b"', jasmine.any(Function));
+        expect(window.xit).toHaveBeenCalledWith('should do stuff with "c"', jasmine.any(Function));
+      });
+
+
+      it('should pass each key-value pair in an object to the handler', function() {
+        var handlerSpy = jasmine.createSpy('handler');
+        spyOn(window, 'xit').andCallFake(function(msg, handler) {
+          handler();
+        });
+        xthey('should do stuff with $prop', {a: 1, b:2, c:3}, handlerSpy);
+        expect(handlerSpy).toHaveBeenCalledWith(1);
+        expect(handlerSpy).toHaveBeenCalledWith(2);
+        expect(handlerSpy).toHaveBeenCalledWith(3);
+      });
+
+
+      it('should call handler with correct `this`', function() {
+        var handlerSpy = jasmine.createSpy('handler');
+        var dummyThis = { name: 'dummyThis' };
+
+        spyOn(window, 'xit').andCallFake(function(msg, handler) {
+          handler.call(dummyThis);
+        });
+
+        xthey('should do stuff with $prop', ['a'], handlerSpy);
+        expect(window.xit).toHaveBeenCalledWith('should do stuff with "a"', jasmine.any(Function));
+        expect(handlerSpy.mostRecentCall.object).toBe(dummyThis);
+      });
+    });
+  });
+
+
   describe('createMockStyleSheet', function() {
 
     it('should allow custom styles to be created and removed when the stylesheet is destroyed',

test/ngMessages/messagesSpec.js

@@ -8,19 +8,6 @@ describe('ngMessages', function() {
     return (element.length ? element[0] : element).querySelectorAll('[ng-message], [ng-message-exp]');
   }
 
-  function they(msg, vals, spec, focus) {
-    forEach(vals, function(val, key) {
-      var m = msg.replace('$prop', key);
-      (focus ? iit : it)(m, function() {
-        spec(val);
-      });
-    });
-  }
-
-  function tthey(msg, vals, spec) {
-    they(msg, vals, spec, true);
-  }
-
   function s(str) {
     return str.replace(/\s+/g,'');
   }