docs($compile): create new error for "missing controller identifier"

Author: caitp

docs/content/error/$compile/noctrl.ngdoc

@@ -4,65 +4,9 @@
 @description
 
 When using the `bindToController` feature of AngularJS, a directive is required
-to have a Controller, in addition to a controller identifier.
+to have a Controller. A controller may be specified by adding a "controller"
+property to the directive definition object. Its value should be either a
+string, or an invokable object (a function, or an array whose last element is a
+function).
 
-For example, the following directives are valid:
-
-```js
-// OKAY, because controller is a string with a label component.
-directive("okay", function() {
-  return {
-    bindToController: true,
-    controller: "myCtrl as $ctrl"
-    scope: {
-      text: "@text"
-    }
-  };
-});
-
-
-// OKAY, because the directive uses the controllerAs property to override
-// the controller identifier.
-directive("okay2", function() {
-  return {
-    bindToController: true,
-    controllerAs: "$ctrl",
-    controller: function() {
-
-    },
-    scope: {
-      text: "@text"
-    }
-  };
-});
-```
-
-While the following are invalid:
-
-```js
-// BAD, because the controller property is a string with no identifier.
-directive("bad", function() {
-  return {
-    bindToController: true,
-    controller: "unlabeledCtrl",
-    scope: {
-      text: "@text"
-    }
-  };
-});
-
-
-// BAD because the controller is not a string (therefore has no identifier),
-// and there is no controllerAs property.
-directive("bad2", function() {
-  return {
-    bindToController: true,
-    controller: function noControllerAs() {
-
-    },
-    scope: {
-      text: "@text"
-    }
-  };
-});
-```
+For more information, see the {@link guide.directive directives guide}.

docs/content/error/$compile/noident.ngdoc

@@ -0,0 +1,71 @@
+@ngdoc error
+@name $compile:noident
+@fullName Controller alias is required.
+@description
+
+When using the `bindToController` feature of AngularJS, a directive is required
+to have a Controller identifier. This can be supplied using the "controllerAs"
+property of the directive object, or alternatively by adding " as ALIAS" to the
+controller name (in either the "controller" property, or where the controller
+was registered).
+
+For example, the following directives are valid:
+
+```js
+// OKAY, because controller is a string with a label component.
+directive("okay", function() {
+  return {
+    bindToController: true,
+    controller: "myCtrl as $ctrl"
+    scope: {
+      text: "@text"
+    }
+  };
+});
+
+
+// OKAY, because the directive uses the controllerAs property to override
+// the controller identifier.
+directive("okay2", function() {
+  return {
+    bindToController: true,
+    controllerAs: "$ctrl",
+    controller: function() {
+
+    },
+    scope: {
+      text: "@text"
+    }
+  };
+});
+```
+
+While the following are invalid:
+
+```js
+// BAD, because the controller property is a string with no identifier.
+directive("bad", function() {
+  return {
+    bindToController: true,
+    controller: "unlabeledCtrl",
+    scope: {
+      text: "@text"
+    }
+  };
+});
+
+
+// BAD because the controller is not a string (therefore has no identifier),
+// and there is no controllerAs property.
+directive("bad2", function() {
+  return {
+    bindToController: true,
+    controller: function noControllerAs() {
+
+    },
+    scope: {
+      text: "@text"
+    }
+  };
+});
+```

src/ng/compile.js

@@ -763,9 +763,17 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
       var controller = directive.controller;
       var controllerAs = directive.controllerAs;
       if (!directive.controller || !identifierForController(controller, controllerAs)) {
-        throw $compileMinErr('noctrl',
-              "Cannot bind to controller without directive '{0}'s controller.",
-              directiveName);
+        if (directive.controller) {
+          // There is a controller, but no identifier or controllerAs property
+          throw $compileMinErr('noident',
+                "Cannot bind to controller without controller alias for directive '{0}'.",
+                directiveName);
+        } else {
+          // There is no controller, there may or may not be a controllerAs property
+          throw $compileMinErr('noctrl',
+                "Cannot bind to controller without directive '{0}'s controller.",
+                directiveName);
+        }
       }
     }
     return bindings;

test/ng/compileSpec.js

@@ -3833,9 +3833,9 @@ describe('$compile', function() {
     });
 
 
-    it('should throw noctrl when missing controllerAs label', function() {
+    it('should throw noident when missing controllerAs label', function() {
       module(function($compileProvider) {
-        $compileProvider.directive('noCtrl', valueFn({
+        $compileProvider.directive('noAlias', valueFn({
           templateUrl: 'test.html',
           scope: {
             'data': '=dirData',
@@ -3848,17 +3848,17 @@ describe('$compile', function() {
       });
       inject(function($compile, $rootScope) {
         expect(function() {
-          $compile('<div no-ctrl>')($rootScope);
-        }).toThrowMinErr('$compile', 'noctrl',
-        'Cannot bind to controller without directive \'noCtrl\'s controller.');
+          $compile('<div no-alias>')($rootScope);
+        }).toThrowMinErr('$compile', 'noident',
+        'Cannot bind to controller without controller alias for directive \'noAlias\'.');
       });
     });
 
 
-    it('should throw noctrl when missing controller label', function() {
+    it('should throw noident when missing controller identifier', function() {
       module(function($compileProvider, $controllerProvider) {
         $controllerProvider.register('myCtrl', function() {});
-        $compileProvider.directive('noCtrl', valueFn({
+        $compileProvider.directive('noAlias', valueFn({
           templateUrl: 'test.html',
           scope: {
             'data': '=dirData',
@@ -3871,9 +3871,9 @@ describe('$compile', function() {
       });
       inject(function($compile, $rootScope) {
         expect(function() {
-          $compile('<div no-ctrl>')($rootScope);
-        }).toThrowMinErr('$compile', 'noctrl',
-        'Cannot bind to controller without directive \'noCtrl\'s controller.');
+          $compile('<div no-alias>')($rootScope);
+        }).toThrowMinErr('$compile', 'noident',
+        'Cannot bind to controller without controller alias for directive \'noAlias\'.');
       });
     });
 
@@ -3998,7 +3998,7 @@ describe('$compile', function() {
         });
         expect(this.str).toBe('Hello, world!');
         expect(this.fn()).toBe('called!');
-      }
+      };
 
       module(function($compileProvider, $controllerProvider) {
         $controllerProvider.register('myCtrl', function() {
@@ -4052,7 +4052,7 @@ describe('$compile', function() {
         });
         expect(this.str).toBe('Hello, world!');
         expect(this.fn()).toBe('called!');
-      }
+      };
 
       module(function($compileProvider, $controllerProvider) {
         $controllerProvider.register('myCtrl', function() {