-
Notifications
You must be signed in to change notification settings - Fork 27.4k
fix($animate): applyStyles from options on leave #10068
Conversation
@petebacondarwin I fixed the test and pulled in latest changed from master // previously
$animate.leave(element, 'off', {
to: { color: 'blue' }
});
// should be
$animate.leave(element, {
to: { color: 'yellow' }
}); the problem was that the test had too many arguments (due to copy/paste of |
missing <code>[options]</code> API that should either be removed from the docs or added in the code @param {object=} options an optional collection of options that will be applied to the element. the tests weren't working for this feature ```javascript $animate.leave(element, 'off', { to: { color: 'blue' } }); assertColor('blue'); //nothing should happen the element is gone anyway ``` you can view the docs here https://ng-click.com/$animate#leave
@petebacondarwin can you remove the [needs: test] tag. The PR is ready for merge and really should have made 1.3.4 release unless I'm missing something. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
I also signed CLA already |
@gdi2290 - thanks for the fix to the test. I have removed the tag. There were changes to the CLA process a few months ago.
|
missing
[options]
API that should either be removed from the docs or added in the code@param {object=} options an optional collection of options that will be applied to the element.
the tests weren't working for this feature
you can view the docs here https://ng-click.com/$animate#leave