Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Angular Test Process for <SELECT> #10201

Closed
ghost opened this issue Nov 23, 2014 · 4 comments
Closed

Angular Test Process for <SELECT> #10201

ghost opened this issue Nov 23, 2014 · 4 comments

Comments

@ghost
Copy link

ghost commented Nov 23, 2014

Would it be possible for someone to work on the code used to test the <SELECT>. It seems there are a large number of issues with this form control and every time one bug is fixed another one or two come up. I'm really wondering if there will ever be a day when there are no select control related issues.

@Narretz
Copy link
Contributor

Narretz commented Nov 23, 2014

What exactly do you mean with

to work on the code used to test the <SELECT>

Do you have any specific suggestions? Obviously it would be better to have all possible cases tested, but this is difficult because select is so complex and can be used in a variety of ways. I believe most of the recent select issues have been causes by a huge refactoring shortly before the 1.3 release. When these issues are fixed, we include tests for broken cases.

@pkozlowski-opensource
Copy link
Member

@rscholey what would really hope is to have a minimal, live reproduce scenario using plunker or similar for the cases you are facing. For example there is #9918 reported but no clear reproduce scenario. We can quickly turn reproduce scenarios into test + fix, provided that we can see the issue.

@ajohnston256
Copy link

@rscholey I was able to reproduce #9714 and just submitted a pull request with a fix. It contains a unit test for using $timeout with select, which will hopefully help to prevent future issues of this kind.

@Narretz
Copy link
Contributor

Narretz commented Nov 25, 2014

Can we close this issue then?

@Narretz Narretz closed this as completed Dec 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants