This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(select): allow ngOptions to be set in $timeout #10203
Closed
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix angular 1.3 regression where empty string was shown Closes angular#9714
|
CLAs look good, thanks! |
| if (this.hasOption(value)) { | ||
| delete optionsMap[value]; | ||
| if (ngModelCtrl.$viewValue == value) { | ||
| if (ngModelCtrl.$viewValue == value && !anySelected) { |
There was a problem hiding this comment.
Can you add a comment to explain why it is necessary to check !anySelected here?
There was a problem hiding this comment.
If the expression on line 215 evaluates to true, then we execute the statement:
this.renderUnknownOption(value);
But, we should only render the unknown option if no option is currently selected. If any option is selected, the select element should only show the values defined in ngOptions.
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Nov 26, 2014
Otherwise, if the removed option was the empty option (value ''), and the currently selected option had a value of 0, the select would think that the currently selected option had been removed, causing the unknown option to be added again. Fixes angular#9714 Fixes angular#10115 Closes angular#10203
|
@ajohnston256 I looked at your solution and saw that there's a simpler fix that fixes the issue more substantially. Can you take a look at #10241? |
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Dec 1, 2014
Otherwise, if the removed option was the empty option (value ''), and the currently selected option had a value of 0, the select would think that the currently selected option had been removed, causing the unknown option to be added again. Fixes angular#9714 Fixes angular#10115 Closes angular#10203
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix angular 1.3 regression where empty string was shown
Closes #9714