This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($emplateRequest): propagate rejection reason when ignoreRequestError... #10266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
|
LGTM, but I am wondering if people may think this is a breaking change |
|
I don't think it is a breaking change - the original promise was rejected before - now we will simply have additional reason of this rejection. |
|
sounds reasonable |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... flag is set
We shouldn't swallow original rejection reason in the promise chain as people still might be interested in the root cause of the pb.