This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(linky): make urls starting with www. into links #10290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
chasefleming
changed the title
| @@ -18,6 +18,10 @@ describe('linky', function() { | |||
| expect(linky(undefined)).not.toBeDefined(); | |||
| }); | |||
|
|
|||
| it('should handle www.', function () { | |||
There was a problem hiding this comment.
remove space between function and ()
|
(Someone should double check my comments on the regexp --- I could be completely full of it right now), but I don't have a problem with this, it is a closer match to the behaviour of markdown, which is kinda nice. |
chasefleming
force-pushed
the
fix/linky
branch
from
750f846 to
a7a5d41
Compare
Remove line break. Change test url Remove space Minor tweak
chasefleming
force-pushed
the
fix/linky
branch
from
22475b1 to
2dafbb2
Compare
|
Ok all requested changes have been made. |
|
looks good to me, just waiting for travis |
|
Passed now. Thanks. |
|
merg'd |
|
Awesome. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter was not turning urls like starting with
www.(likewww.example.com) into links. These changes address that.