Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat($rootScope): allow passing locals argument to $evalAsync #10390

Closed
wants to merge 1 commit into from
Closed

feat($rootScope): allow passing locals argument to $evalAsync #10390

wants to merge 1 commit into from

Conversation

shahata
Copy link
Contributor

@shahata shahata commented Dec 9, 2014

No description provided.

@googlebot
Copy link

CLAs look good, thanks!

@caitp
Copy link
Contributor

caitp commented Dec 9, 2014

tbh, I asked if we wanted this when implementing $$applyAsync, and I recall we decided against it as there weren't really any use cases that depended on it. I suppose it could simplify some of the async ng-event handlers a little bit, though (no strong opinion on this one way or the other)

@caitp
Copy link
Contributor

caitp commented Dec 10, 2014

@petebacondarwin / @IgorMinar do we want to do this?

@petebacondarwin
Copy link
Contributor

@shahata - do you have a compelling use case for this feature?

@shahata
Copy link
Contributor Author

shahata commented Dec 13, 2014

No, I just thought it makes sense that ppl will be able to do:

scope.$evalAsync(exp, locals);

instead of the more verbose:

scope.$evalAsync(function () {
  scope.$eval(exp, locals);
});

@petebacondarwin
Copy link
Contributor

LGTM

@petebacondarwin petebacondarwin modified the milestones: 1.3.7, 1.3.x Dec 15, 2014
@petebacondarwin petebacondarwin self-assigned this Dec 15, 2014
@shahata shahata closed this in 9b96cea Dec 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants