This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngClass): handle multi-class definitions as an element of an array #10651
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles multi-class definition as an element of an array Closes angular#8578
|
@lgalfaso hmm, I've got the impression that it won't work in all the case - since you can have expressions as part of the ngClass array you can imagine having spaces being part of those expressions - one contrived example: Didn't look deeper, but if you believe that this works for this case as well, we should add more tests. |
|
Oh, wait, on the directive level we are going to have already an array of strings, right? |
|
@lgalfaso sorry for the noise. LGTM. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles multi-class definition as an element of an array
Closes #8578