docs(ngModelOptions): Config objects cannot be shared among ngModelOptions instances.

[mtr]

Just thought I'd add a note about this issue since it hit me during development and I cannot find any note about it in the documentation. Looking at the source code, it seems that the changes to the object made in the block of https://github.com/angular/angular.js/blob/master/src/ng/directive/ngModel.js#L1223 are not idempotent, but I guess that's a design choice, not a bug?

[googlebot]

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

[mtr]

A few moments ago, I signed the CLA.

[googlebot]

CLAs look good, thanks!

[pkozlowski-opensource]

@mtr let's see what others think but generally speaking I'm against dotting docs with all the possible use-cases that people might find confusing. If this scenario is common we can fix it in the code we should fix the underlying issue. If it is not fixable and very common only then we should add a note to the docs, IMO

[mtr]

@pkozlowski-opensource That makes sense. I think the underlying code should be fixed then, and I think I see how that can be done quite easily, but I'm not sure when I'll get the time to do it. If I find the time, I'll submit a pull request for fixing the underlying issue.

[pkozlowski-opensource]

@mtr ok, send a PR for the code fix when you've got time then. Or at least open an issue with the reproduce scenario so maybe someone else will be able to fix it faster.

Closing this PR for now.