fix($location): strip off empty hash segments when comparing #10748
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
I've already signed the CLA as a corporation. The corporation name is 'Whatever SA'. Should I resend the CLA to cla-submissions@google.com? |
Backported from e93710f The url is the same whether or not there is an empty `#` marker at the end. This prevents unwanted calls to update the browser, since the browser is automatically applying an empty hash if necessary to prevent page reloads. Closes angular#9635
|
So the tests fail on travis because of a timeout, but everything works fine when I run the tests locally. Is there anything I can do to fix that? |
|
CLAs look good, thanks! |
|
Landed in 1.2.x as e81b2f7. |
Backported from 45f5dad The url is the same whether or not there is an empty `#` marker at the end. This prevents unwanted calls to update the browser, since the browser is automatically applying an empty hash if necessary to prevent page reloads. Closes angular#9635 Closes angular#10748
Backported from e93710f
The url is the same whether or not there is an empty
#marker at the end.This prevents unwanted calls to update the browser, since the browser is
automatically applying an empty hash if necessary to prevent page reloads.
Closes #9635