This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animate): ensure no transitions are applied when an empty inline style object is provided #10770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… style object is provided Closes angular#10613
| @@ -1869,7 +1869,7 @@ angular.module('ngAnimate', ['ng']) | |||
| return; | |||
| } | |||
|
|
|||
| if (!staggerTime && styles) { | |||
| if (!staggerTime && styles && Object.keys(styles).length > 0) { | |||
There was a problem hiding this comment.
Is it possible that styles could be a string? If so then calling Object.keys would throw an exception.
There was a problem hiding this comment.
Oh I think it cannot since in $animate.animate(element, from, to, ...) from and to are both supposed to be objects.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10613