This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(htmlAnchorDirective): remove "element !== target element" check #10866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not really needed due to the way click events are dispatched and propagated
caitp
added a commit
that referenced
this pull request
Jan 26, 2015
It's not really needed due to the way click events are dispatched and propagated Closes #10866
nidico
added a commit
to liqd/adhocracy3
that referenced
this pull request
Feb 18, 2015
This was a bug in angular which caused `element.off("click.adh_href")`
remove too many click events.
This is fixed in angular/angular.js#10866 in version 1.3.11 .
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not really needed due to the way click events are dispatched and propagated