Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngSanitize): do not ignore white-listed svg camelCased attributes #10990

Closed
wants to merge 1 commit into from
Closed

fix(ngSanitize): do not ignore white-listed svg camelCased attributes #10990

wants to merge 1 commit into from
+13 −1

Conversation

hugomn
Copy link
Contributor

@hugomn hugomn commented Feb 6, 2015

@hugomn
fix(ngSanitize): Do not ignore white-listed svg camelCased attributes

Verified

This commit was signed with the committer’s verified signature. The key has expired.
12101111 韩朴宇
GPG key ID: 97785FADF38A97DC
Expired
Verified
Learn about vigilant mode
6a46da4 
Closes angular#10779
@hugomn hugomn changed the title fix(ngSanitize): Do not ignore white-listed svg camelCased attributes fix(ngSanitize): do not ignore white-listed svg camelCased attributes Feb 6, 2015
@pkozlowski-opensource
Copy link
Member

@hugomn it seems like the change is good but it needs more work:

Could you please have a look at those items so we can merge your PR? Thnx!

@pkozlowski-opensource pkozlowski-opensource self-assigned this Feb 20, 2015
pkozlowski-opensource pushed a commit to pkozlowski-opensource/angular.js that referenced this pull request Feb 21, 2015
@hugomn @pkozlowski-opensource
fix(ngSanitize): Do not ignore white-listed svg camelCased attributes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
74f64c2 
Closes angular#10779
Closes angular#10990
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Feb 21, 2015
Closed
@pkozlowski-opensource
Copy link
Member

@hugomn never mind, it turned out that travis failure was a flake and I did the cleanup myself. Merging.

@hugomn
Copy link
Contributor Author

hugomn commented Feb 23, 2015

Thanks, @pkozlowski-opensource! =)

netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
@hugomn @netman92
fix(ngSanitize): Do not ignore white-listed svg camelCased attributes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d1bcfa7 
Closes angular#10779
Closes angular#10990
Closes angular#11124
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@pkozlowski-opensource pkozlowski-opensource

Labels
cla: yes component: ngSanitize needs: work type: bug
Projects
None yet
Milestone
1.4.0-beta.6 / 1.3.15
Development

Successfully merging this pull request may close these issues.

ngSanitize: camel-cased attributes in SVG accidentally deleted
3 participants
@hugomn @pkozlowski-opensource @googlebot